Skip to content

[15.0][FIX] ci: adapt regular expression that select modules to new column in table#3278

Merged
pedrobaeza merged 1 commit intoOCA:15.0from
StefanRijnhart:fix/15.0/ci/module_expression
Jun 15, 2022
Merged

[15.0][FIX] ci: adapt regular expression that select modules to new column in table#3278
pedrobaeza merged 1 commit intoOCA:15.0from
StefanRijnhart:fix/15.0/ci/module_expression

Conversation

@StefanRijnhart
Copy link
Member

@StefanRijnhart StefanRijnhart commented Jun 14, 2022

Currently, only 'base' is upgraded even when other modules are set to Done (see #3273)

-- edit -- Now merged in #3273, so maybe that one can be merged sooner rather than later, and rather than this one.

@StefanRijnhart StefanRijnhart changed the title [FIX] ci: adapt regular expression that select modules to new column in table [15.0][FIX] ci: adapt regular expression that select modules to new column in table Jun 14, 2022
@StefanRijnhart StefanRijnhart added this to the 15.0 milestone Jun 14, 2022
@StefanRijnhart StefanRijnhart marked this pull request as draft June 14, 2022 09:54
@pedrobaeza
Copy link
Member

Can you please explain a bit the changes in the regexp and why this has changed over other versions? You know they are very hard to be read

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we don't have the problem in V14.

@StefanRijnhart
Copy link
Member Author

Oh, sorry for not being clear on this. The expression for 14 fails on the table in 15 because it has an extra column:

Module coverage 13.0 -> 14.0
============================

.. include:: coverage_legend.rst

+--------------------------------------------+-------------------------------------------------+
|Module                                      |Status                                           |
+============================================+=================================================+
|account                                     | Done                                            |
+--------------------------------------------+-------------------------------------------------+
| |del| account_analytic_default             | Merged into account                             |
+--------------------------------------------+-------------------------------------------------+
| |del| account_analytic_default_hr_expense  | Merged into hr_expense                          |
Module coverage 14.0 -> 15.0
============================

.. include:: coverage_legend.rst

+-------------------------------------------------+----------------------+-------------------------------------------------+
| Module                                          | Status               + Extra Information                               |
+=================================================+======================+=================================================+
| account                                         |                      |                                                 |
+-------------------------------------------------+----------------------+-------------------------------------------------+
| account_check_printing                          |                      |No DB layout changes.                            |
+-------------------------------------------------+----------------------+-------------------------------------------------+

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the information. Not sure this extra column is a good idea, but anyways, the CI should work

@pedrobaeza pedrobaeza marked this pull request as ready for review June 15, 2022 05:22
@pedrobaeza pedrobaeza merged commit 9b06cf7 into OCA:15.0 Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants