[14.0][OU-IMP] account: Compute stored function fields by SQL#3626
Merged
pedrobaeza merged 12 commits intoOCA:14.0from Mar 31, 2023
Merged
[14.0][OU-IMP] account: Compute stored function fields by SQL#3626pedrobaeza merged 12 commits intoOCA:14.0from
pedrobaeza merged 12 commits intoOCA:14.0from
Conversation
Contributor
|
Hi @pedrobaeza, @MiquelRForgeFlow, @StefanRijnhart, |
etobella
force-pushed
the
14.0-imp-account
branch
12 times, most recently
from
ae218ba to
b6cd773
Compare
MiquelRForgeFlow
changed the title
carlosdauden
approved these changes
Mar 30, 2023
Contributor
|
This PR has the |
…account payment by SQL
pedrobaeza
force-pushed
the
14.0-imp-account
branch
from
b6cd773 to
3c6846b
Compare
pedrobaeza
changed the title
- Don't use account_move, as for draft payment, they are not available, and anyway, we can extract the needed data from account_journal. - Perform only 2 queries for destination_account_id instead of 8, and also do it more readable.
- It's more expressive and shorter doing JOIN with ON clause. - is_reconciled flag was not updated. - Nested CASE for shorting the query and making it more readable. - Extra: Assign False by default on column creation for avoiding NULL/False dualities.
pedrobaeza
force-pushed
the
14.0-imp-account
branch
from
3c6846b to
9a0bef5
Compare
Merged
hhgabelgaard
added a commit
to steingabelgaard/OpenUpgrade
that referenced
this pull request
Nov 14, 2025
It is due to our use of account_move_name_sequence in v15 we are missing these SQL lifted from OCA#3626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When managing files from account.move, account.move.line, account.payment, account.bank.statement or account.bank.statement.line we should always migrate them by SQL, not using the computed function (it could take hours or, even worse, fail for a Memory failure)
Candidate fields