[14.0][OU-FIX] fix account.partial.reconcile currency

[huguesdk]

fix queries pre-filling the debit_currency_id and credit_currency_id fields of account.partial.reconcile records: debit_move_id and credit_move_id are many2one fields to account.move.line, not to account.move. this resulted in null columns, ignoring the records when computing account.move.line.amount_residual in odoo 16.

here is how to fix existing data:

self.env.cr.execute(
    """
    update account_partial_reconcile as apr
    set debit_currency_id = coalesce(aml.currency_id, rc.currency_id)
    from account_move_line as aml,
        res_company as rc
    where
        debit_currency_id is null and
        aml.id = apr.debit_move_id and
        rc.id = aml.company_id
    """
)
self.env.cr.execute(
    """
    update account_partial_reconcile as apr
    set credit_currency_id = coalesce(aml.currency_id, rc.currency_id)
    from account_move_line as aml,
        res_company as rc
    where
        credit_currency_id is null and
        aml.id = apr.credit_move_id and
        rc.id = aml.company_id
    """
)
self.env["account.move.line"].search(
    [
        ("reconciled", "=", False),
        "|",
        ("matched_credit_ids", "!=", False),
        ("matched_debit_ids", "!=", False),
    ]
)._compute_amount_residual()

[OCA-git-bot]

Hi @pedrobaeza, @StefanRijnhart, @MiquelRForgeFlow,
some modules you are maintaining are being modified, check this out!

[remytms]

LGTM.

[MiquelRForgeFlow]

Thanks, LGTM! (blame to @etobella 😄)

[etobella]

🤦

[huguesdk]

wow, that was a super fast merge, thanks!

@etobella in your defense, the fields are very badly named. it took me some time to notice it. this states the importance of naming fields in a meaningful way. you can transfer your blame to odoo. ☺️

[etobella]

Don't worry, I didn't took it badly, it was my mistake, but well, for this reason we have a community. Altogether, we are able to find solutions and fix the mistakes on the software 😉