[19.0][MIG] hr_*: analyses for 13 simple submodules#5634
Draft
dnplkndll wants to merge 1 commit into
Draft
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
2 tasks
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
Adds upgrade_analysis_work.txt for the 13 unclaimed hr_* submodules
whose 19.0 deltas are auto-handled by Odoo's standard upgrade flow.
Modules covered:
hr_calendar, hr_fleet, hr_gamification, hr_homeworking, hr_livechat,
hr_maintenance, hr_org_chart, hr_presence, hr_recruitment_sms,
hr_skills_event, hr_skills_slides, hr_skills_survey, hr_timesheet.
All blocks annotate as # NOTHING TO DO — NEW XML records are created
by the 19.0 module load, DEL records are removed by the standard
upgrade flow, "module is now 'X' ('Y')" entries are field-ownership
shifts that the standard upgrade reconciles, and selection_keys /
function-becomes-stored / type changes are auto-handled at registry
init.
Mirrors hbrunn's existing annotation-only [MIG] PRs ([MIG] bus,
[MIG] http_routing, [MIG] resource_mail). The 4 substantial
hr_attendance / hr_skills / hr_recruitment_skills /
hr_holidays_attendance modules are deliberately split into a
companion PR for focused review of the overtime/skills refactor.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by hbrunn.
hr_recruitment_survey and hr_work_entry_holidays have no analysis
delta — left for a future regen.
dnplkndll
force-pushed
the
19.0-mig-hr-family-trivial
branch
from
dae82d1 to
802170b
Compare
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 15, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
dnplkndll
added a commit
to ledoent/OpenUpgrade
that referenced
this pull request
May 16, 2026
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
upgrade_analysis_work.txtfor 13 unclaimed hr_* submoduleswhose 19.0 deltas are entirely auto-handled by Odoo's standard upgrade
flow. Annotation-only, no code.
Modules covered:
hr_calendar,hr_fleet,hr_gamification,hr_homeworking,hr_livechat,hr_maintenance,hr_org_chart,hr_presence,hr_recruitment_sms,hr_skills_event,hr_skills_slides,hr_skills_survey,hr_timesheet.The 4 substantial hr_* submodules (
hr_attendance,hr_skills,hr_recruitment_skills,hr_holidays_attendance) are deferred toa companion PR for focused review of the overtime + skills refactor.
Why
All blocks annotate as
# NOTHING TO DO:ir.ui.view,ir.actions.\*,ir.model.access,ir.rule,ir.ui.menu,ir.model.constraint) — created bythe 19.0 module load.
review, OpenUpgrade preserves data and lets
database_cleanuphandle residuals.
hasdefault: defaultor function-stored — Odoopopulates on registry init.
module is now 'X' ('Y')— field-ownership shift; reconciled byOdoo's standard upgrade.
auto-handled at registry init.
Precedent
Mirrors hbrunn's existing annotation-only
[MIG]PRs:[MIG] bus,[MIG] http_routing,[MIG] resource_mail,[MIG] pos_restaurant. Same single-comment-per-populated-sectionstyle; empty sections left unannotated.
Scope notes
hr_expense✅,hr_holidays✅,hr_work_entry✅— already done.
hr_recruitment([19.0][MIG] hr_recruitment #5612) — in flight by @hbrunn, untouched.hr_recruitment_survey,hr_work_entry_holidays— analyzerproduced no diff; skip until next regen.
Test plan
pre-commit run --files <all new files>: clean.Companion / context PRs
[19.0][IMP] hr: backfill NULL create_date/write_date[19.0][FIX] loyalty: clear stale mail.template.lang[19.0][MIG] website_*: complete analyses for 31 uncharted modules— same shape, same review precedent.
Companion PR for the 4 complex hr_* submodules to follow shortly.