Skip to content

[19.0][MIG] hr_*: overtime + skills refactor (4 submodules)#5635

Draft
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-mig-hr-family-overtime-skills
Draft

[19.0][MIG] hr_*: overtime + skills refactor (4 submodules)#5635
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-mig-hr-family-overtime-skills

Conversation

@dnplkndll
Copy link
Copy Markdown

What

Adds upgrade_analysis_work.txt for 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.

Companion to #5634 (13 simple hr_* submodules). Split this way for
focused review of the model-rename refactors.

Why

The substantial change here is two model renames already in
apriori.renamed_models:

18.0 model 19.0 model Touched in
hr.attendance.overtime hr.attendance.overtime.line hr_attendance, hr_holidays_attendance
hr.candidate.skill hr.applicant.skill hr_recruitment_skills

Apriori handles both via update_module_names /
rename_models in base/19.0.1.3/pre-migration.

The m2m hr.applicant.skill_ids analysis line reads
table is now 'hr_applicant_hr_skill_rel' ('False'). The 18.0 value
False indicates the table name was unspecified, so Odoo
auto-named it. For hr.applicanthr.skill, the
alphabetically-sorted auto-name is hr_applicant_hr_skill_rel
identical to the new explicit name. No rename_tables needed.
Same reasoning for any analogous m2m in hr_skills.

Other changes are auto-handled:

  • NEW models (overtime rule, ruleset, skill history report,
    certification report, hr.individual.skill.mixin, hr.job.skill) —
    created by the 19.0 module load.
  • NEW fields all carry hasdefault: default or
    hasdefault: compute.
  • NEW required+function-stored fields (e.g. hr.attendance.date,
    hr.attendance.overtime.line.status) — Odoo computes at
    registry init.
  • DEL fields/views/access/rules/menus — preserved per [19.0][MIG] partner_autocomplete: cleanup obsolete res.partner/res.company fields #5631 review;
    database_cleanup handles residuals once the new version is in
    active use.

How

Pure annotations, no code. Each work-doc has one # DONE block for
the apriori-handled model rename plus one # NOTHING TO DO per
populated section.

Scope notes

  • hr, hr_expense, hr_holidays, hr_work_entry already
    done in earlier PRs.
  • hr_recruitment is in flight by @hbrunn in [19.0][MIG] hr_recruitment #5612 — not touched.
  • hr_recruitment_survey and hr_work_entry_holidays had no
    analysis diff; skipped, will be picked up on a future analyzer
    regen.

Test plan

  • pre-commit run --files <all new files>: clean.
  • OCA CI green.

Related PRs

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels May 15, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr-family-overtime-skills branch 2 times, most recently from 376a431 to ada78a5 Compare May 15, 2026 18:42
@dnplkndll dnplkndll marked this pull request as draft May 15, 2026 18:53
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr-family-overtime-skills branch from ada78a5 to 4dad69b Compare May 15, 2026 18:54
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.

These cluster into two logical refactors that are already covered by
apriori.renamed_models:

  hr.attendance.overtime → hr.attendance.overtime.line
    (hr_attendance, hr_holidays_attendance)
  hr.candidate.skill → hr.applicant.skill
    (hr_recruitment_skills)

For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.

NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.

Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.

hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
@dnplkndll dnplkndll force-pushed the 19.0-mig-hr-family-overtime-skills branch from 4dad69b to b17af59 Compare May 15, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:openupgrade_scripts Module openupgrade_scripts series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants