[19.0][MIG] hr_*: overtime + skills refactor (4 submodules)#5635
Draft
dnplkndll wants to merge 1 commit into
Draft
[19.0][MIG] hr_*: overtime + skills refactor (4 submodules)#5635dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
376a431 to
ada78a5
Compare
ada78a5 to
4dad69b
Compare
Adds upgrade_analysis_work.txt for the 4 hr_* submodules with
substantial 19.0 deltas: hr_attendance, hr_holidays_attendance,
hr_skills, hr_recruitment_skills.
These cluster into two logical refactors that are already covered by
apriori.renamed_models:
hr.attendance.overtime → hr.attendance.overtime.line
(hr_attendance, hr_holidays_attendance)
hr.candidate.skill → hr.applicant.skill
(hr_recruitment_skills)
For both clusters the apriori rename handles the data move. The
many2many table "now hr_applicant_hr_skill_rel ('False')" matches
Odoo's auto-naming for hr.applicant ↔ hr.skill (alphabetical
hr_applicant_hr_skill_rel) and hr.employee ↔ hr.skill, so no explicit
rename_tables is needed.
NEW models (overtime rule, overtime ruleset, skill history report,
certification report, hr.individual.skill.mixin, hr.job.skill) are
created by the 19.0 module load. NEW fields all carry hasdefault
(default or compute). NEW required+function fields are computed by
Odoo at registry init. DEL fields/views/access are preserved per the
maintainer's philosophy; database_cleanup handles residuals once 19.0
is in active use.
Companion to OCA#5634 ([19.0][MIG] hr_* for 13 simple submodules); same
review precedent as OCA#5633.
hr, hr_expense, hr_holidays, hr_work_entry are already done.
hr_recruitment (OCA#5612) is in flight by @hbrunn.
4dad69b to
b17af59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
upgrade_analysis_work.txtfor 4 hr_* submodules withsubstantial 19.0 deltas:
hr_attendance,hr_holidays_attendance,hr_skills,hr_recruitment_skills.Companion to #5634 (13 simple hr_* submodules). Split this way for
focused review of the model-rename refactors.
Why
The substantial change here is two model renames already in
apriori.renamed_models:hr.attendance.overtimehr.attendance.overtime.linehr.candidate.skillhr.applicant.skillApriori handles both via
update_module_names/rename_modelsin base/19.0.1.3/pre-migration.The m2m
hr.applicant.skill_idsanalysis line readstable is now 'hr_applicant_hr_skill_rel' ('False'). The 18.0 valueFalseindicates the table name was unspecified, so Odooauto-named it. For
hr.applicant↔hr.skill, thealphabetically-sorted auto-name is
hr_applicant_hr_skill_rel—identical to the new explicit name. No
rename_tablesneeded.Same reasoning for any analogous m2m in hr_skills.
Other changes are auto-handled:
certification report, hr.individual.skill.mixin, hr.job.skill) —
created by the 19.0 module load.
hasdefault: defaultorhasdefault: compute.hr.attendance.date,hr.attendance.overtime.line.status) — Odoo computes atregistry init.
database_cleanuphandles residuals once the new version is inactive use.
How
Pure annotations, no code. Each work-doc has one
# DONEblock forthe apriori-handled model rename plus one
# NOTHING TO DOperpopulated section.
Scope notes
hr,hr_expense,hr_holidays,hr_work_entryalreadydone in earlier PRs.
hr_recruitmentis in flight by @hbrunn in [19.0][MIG] hr_recruitment #5612 — not touched.hr_recruitment_surveyandhr_work_entry_holidayshad noanalysis diff; skipped, will be picked up on a future analyzer
regen.
Test plan
pre-commit run --files <all new files>: clean.Related PRs
[19.0][IMP] hr: backfill NULL create_date/write_date[19.0][FIX] loyalty: clear stale mail.template.lang[19.0][MIG] website_*: complete analyses for 31 modules[19.0][MIG] hr_*: 13 simple submodules(companion)