feat: drop Text component in favour of Text component - #1663
Conversation
f7475bd to
58983c8
Compare
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
9645aae to
40b642b
Compare
|
Visit the preview URL for this PR (updated for commit 56c851c): https://onearmy-next--pr1663-chore-move-text-to-c-tm3cqfnf.web.app (expires Wed, 07 Sep 2022 21:11:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
40b642b to
56c851c
Compare
|
@davehakkens Okay to approve these changes? |
|
Thanks for tidying this, I definitely waas not a fan of the layers of minor wrappers (anything we need to configure with text should be themeable anyways, and also was leading to a bunch of knock-ons passing props like |
|
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
masterbranch mergedPR Type
Description
Removes our own
Textcomponent in favour of directly using theTextcomponent from theme-ui. Our implementation was a thin wrapper that introduced a few attributes liketxtCenterwhich seems like it would be better to set via thesxattribute.This introduces changes like the following:
There are no user facing changes here, the intention here is to simplify the experience when building UI components. Before there were two possible options for including
Textnow there is only one.