Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance release #1599

Merged
merged 23 commits into from
Nov 18, 2021
Merged

Maintenance release #1599

merged 23 commits into from
Nov 18, 2021

Conversation

mrsuciu
Copy link
Contributor

@mrsuciu mrsuciu commented Nov 18, 2021

Maintenance release

mregen and others added 23 commits October 15, 2021 21:12
- add boiler, data and memory buffer sample node managers to reference server
- exclude Quickstarts.Servers from code coverage
Bumps [Portable.BouncyCastle](https://github.com/novotnyllc/bc-csharp) from 1.8.10 to 1.9.0.
- [Release notes](https://github.com/novotnyllc/bc-csharp/releases)
- [Commits](novotnyllc/bc-csharp@pcl-v1.8.10...pcl-v1.9.0)

---
updated-dependencies:
- dependency-name: Portable.BouncyCastle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Commits](microsoft/vstest@v16.11.0...v17.0.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
-fixes for complex types:
  - a structure which contains an enum from namespace 0 can not be created. fixes #1561.
  - a structure with multidimensional array may lead to a endless loop in `ComplexTypeSystem.Load`
  - a malformed namespace Uri which contains a space character prevents creation of type system.
  - select endpoint doesn't pick the right scheme if the default endpoint must be picked
-prep for net472 or greater and net5.0 or greater build, only build #ifdef
Bumps [System.Io.Pipelines](https://github.com/dotnet/runtime) from 4.5.4 to 5.0.1.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits/v5.0.1)

---
updated-dependencies:
- dependency-name: System.Io.Pipelines
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [System.Text.Encodings.Web](https://github.com/dotnet/runtime) from 4.5.1 to 5.0.1.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](https://github.com/dotnet/runtime/commits/v5.0.1)

---
updated-dependencies:
- dependency-name: System.Text.Encodings.Web
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This can cause considerable slowdown when connecting to multiple MQTT
destinations or when waiting for pubsub application to start, and is
unecessary.

Instead, the DisconnectHandler fires on connect fail as well, so this
implementation works.
- add build targets for net6.0
- fix new warnings in VS2022 compiler
* fix code quality display on main page

* Update README.md

fix build status
only output the DataTypeDefinitionId and ReferenceTypeId vor var/objects
fixes nodeset output of #1532 
fixes OPCFoundation/UA-ModelCompiler#94
Added null check to structureType.DefaultEncodingId in the ReadNonValueAttribute method
Bumps [MQTTnet](https://github.com/chkr1011/MQTTnet) from 3.0.16 to 3.0.17.
- [Release notes](https://github.com/chkr1011/MQTTnet/releases)
- [Commits](dotnet/MQTTnet@v3.0.16...v3.0.17)

---
updated-dependencies:
- dependency-name: MQTTnet
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
- HasTypeDefinition and TypeDefinitionId should only exist for Object/Variable in .uanodes
- fix binary export for .uanodes
- #1574 missed the binary output case, only fixed xml export
- fixes #1532 
- fixes OPCFoundation/UA-ModelCompiler#94
- fix the default and sample models in this repo

note --> ModelCompiler needs to use the updated core lib to produce the same output
* Add IEquatable interface for DataValue, StatusCode and NumericRange types

- Performance update

Implement strongly typed Equals() method and IEquatable for DataValue, StatusCode and NumericRange types so no boxing is required.
This brings a performance improvement for servers with high number of dynamic nodes and monitored items created where the compare method of DataValue is called intensively (100k -200k/sec)
…, since there is a very small probability for an enumeration to contain one field only (#1579)
- Add pipeline steps with VS2022 hosted images and .NET 6 install on linux/mac
- Nuget build with net6.0 binaries
Co-authored-by: mrsuciu <Mircea-Adrian.Suciu@softing.com>
…formation (#1591)

- fix uncontrolled format string and clear text storage of sensitive information issues flagged by CodeQL
- fix the complex types of the test nodeset (requires OPCFoundation/UA-ModelCompiler#96)
- improve some client / server tests
- add tests for complex types datatype definition integrity on ref server, validate bsd and xml dictionaries in the test server (open issue:  https://mantis.opcfoundation.org/view.php?id=7393, xml validation always failing)
- improve server fixture, to allow for custom config changes 
- fix an issue that caused kestrel not start on windows/.NET Core 3.1 and above, when a new certificate was issued, thereby ignoring all https client tests.
Bumps [MQTTnet](https://github.com/chkr1011/MQTTnet) from 3.0.17 to 3.1.0.
- [Release notes](https://github.com/chkr1011/MQTTnet/releases)
- [Commits](dotnet/MQTTnet@v3.0.17...v3.1.0)

---
updated-dependencies:
- dependency-name: MQTTnet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… specified instead of a hostname (#1596); should fix issue #1581

* Binding to a specific NIC is implicitly implied when an IP address is specified instead of a hostname; Removed the redundant flag BindToSpecifiedAddress.
Bumps [Microsoft.SourceLink.GitHub](https://github.com/dotnet/sourcelink) from 1.0.0 to 1.1.1.
- [Release notes](https://github.com/dotnet/sourcelink/releases)
- [Commits](dotnet/sourcelink@1.0.0...1.1.1)

---
updated-dependencies:
- dependency-name: Microsoft.SourceLink.GitHub
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@CLAassistant
Copy link

CLAassistant commented Nov 18, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
6 out of 7 committers have signed the CLA.

✅ mregen
✅ bdovaz
✅ einarmo
✅ opcfoundation-org
✅ AlinMoldovean
✅ mrsuciu
❌ dependabot[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@mrsuciu mrsuciu requested a review from mregen November 18, 2021 09:08
@lgtm-com
Copy link

lgtm-com bot commented Nov 18, 2021

This pull request introduces 36 alerts when merging 31e4a2b into 0624121 - view on LGTM.com

new alerts:

  • 13 for Too many 'ref' parameters
  • 12 for Dereferenced variable may be null
  • 6 for Useless assignment to local variable
  • 4 for Container contents are never accessed
  • 1 for Constant condition

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #1599 (31e4a2b) into release/1.4.367 (f9381b8) will increase coverage by 0.72%.
The diff coverage is 65.45%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/1.4.367    #1599      +/-   ##
===================================================
+ Coverage            52.69%   53.41%   +0.72%     
===================================================
  Files                  316      312       -4     
  Lines                59012    57364    -1648     
===================================================
- Hits                 31094    30640     -454     
+ Misses               27918    26724    -1194     
Impacted Files Coverage Δ
Libraries/Opc.Ua.Client/CoreClientUtils.cs 46.47% <0.00%> (ø)
Libraries/Opc.Ua.Client/Session.cs 61.61% <0.00%> (-0.26%) ⬇️
...ies/Opc.Ua.Gds.Client.Common/CertificateWrapper.cs 0.00% <0.00%> (ø)
...a.Gds.Client.Common/GlobalDiscoveryServerClient.cs 73.50% <ø> (ø)
...aries/Opc.Ua.PubSub/Transport/MqttClientCreator.cs 0.00% <0.00%> (ø)
...ificates/Extensions/X509SubjectAltNameExtension.cs 84.67% <ø> (ø)
...ries/Opc.Ua.Security.Certificates/PEM/PEMReader.cs 93.75% <ø> (ø)
...Certificates/X509Certificate/CertificateBuilder.cs 83.70% <ø> (ø)
...urity.Certificates/X509Certificate/X509PfxUtils.cs 70.37% <ø> (ø)
...ore/Security/Certificates/CertificateIdentifier.cs 25.57% <ø> (ø)
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beede47...31e4a2b. Read the comment docs.

@mrsuciu mrsuciu merged commit 58bbc0c into release/1.4.367 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants