Merged
Conversation
The introductory sentence could be read as implying definitions that contradict the body of the article.
* Fix invalid Windows file system paths * Add escape characters
Changed "Visual basic" to "Visual Basic" for the description of the Get Visual Basic link.
* Fixed broken links in interop docs * Updated additional links * Removed 'en-us' from URLs
Visual Basic Fundamentals for Absolute Beginners link was directing to a list of courses, not really related to VB. I've updated the link directly to the course. I did check to see if the course was in other languages before putting in the en-US link - looks like it's available only in English.
Change "new ValidationResult(true, null)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.
* article and code moved * interim checkin Switching tasks. * checkin to run test build I want to see if I can use local functions in C# interactive. * finish samples and new draft Ready for my first review. * fix build errors * proofread * update per feedback. * respond to feedback. * additional feedback. * respond to feedback.
Change "New ValidationResult(True, Nothing)" to "ValidationResult.ValidResult", since it looks a little cleaner and the property was explicitly designed for that use.
Without this, the rest of the file renders incorrectly.
* Removed an excessive "and" * Removed some text that didn't seem overly clear.
* Fix markdown link * feedback
* fixed typo * fix typo
Just noticed on docs.microsoft.com that these code blocks don't have syntax highlighting, which does not adhere to the style guide
* Add UWP as platform that supports .NET Standard https://blogs.msdn.microsoft.com/dotnet/2017/10/10/announcing-uwp-support-for-net-standard-2-0/ * Add platforms; remove versions; add link Instead of listing the same platforms that are listed on https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support and having to maintain both lists as new versions are released, just mention the platforms here and link to the existing table with versions. Closes dotnet#3814 * feedback
* < and > wrong < and > were not in code * Updated xref Updated xref to correct signature * removing tickmarks and overloads * some other minor fixes
* Operator new doesn't create structs on the stack * Small improvements to operator new * Structs can contain resources too * Mention garbage collector * Clarified when value types are destroyed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe your changes here.
Fixes #Issue_Number (if available)