This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Pre-release merge of develop into master #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/OS2Forms/os2forms_forloeb into 43378_support_multiple_parties_with_multiple_webforms
Update README.md
… shouldn't make decisions about which theme to use. Leave that up to whichever install profile is being used.
Remove custom_theme and gin dependencies. The os2forms_forloeb module shouldn't make decisions about which theme to use. Leave that up to whichever install profile is being used.
…ith_multiple_webforms Support multiple parties with multiple webforms
Remove rules modules as dependency
…ic and reusable for everyone.
…generic [#46780] Removed all parts of HK/Holstebro, to make the webform gener…
…k_type [#46800] Created new task-type for inheriting webform in flow
…k_type [#46800] Adding all form fields to 'prepareTaskForSave'
* Merge develop with master (#90) * Fixing composer.lock to fetch fixed Forløb module release. * Add function to set username from webform submission. * Adding example webforms to enable flow with multiple webforms. * Make basic workflow work, without copying of fields. * New task class in place - now ready to implement the functionality. * Commit day's work. * Added form_alter hook to intercept submit on WebformMultiple task. * It works, next step some prettification. * Lint changes. * Fix notification by variable for part1 * Changed so that field names in source forms are prefixed with unique ID. * Remove composer update from CI check * Set composer update to get latest version per tag * Brushup before review. * Travis CI fix. * Remove tag versioning of forloeb module * Fix linting error. * Update README.md * Refactor unused webforms and flows * Add, install and configure r4032login module * Adjust description text * Rename template * Change category * Remove custom_theme and gin dependencies. The os2forms_forloeb module shouldn't make decisions about which theme to use. Leave that up to whichever install profile is being used. * Remove rules modules as dependency * lock to dev branch * Remove Forløb profile as a dependency Co-authored-by: Carsten Agger <carstena@magenta-aps.dk> Co-authored-by: Carsten Agger <carstena@magenta.dk> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> * Pre-release PR develop into master (#95) * Fixing composer.lock to fetch fixed Forløb module release. * Add function to set username from webform submission. * Adding example webforms to enable flow with multiple webforms. * Make basic workflow work, without copying of fields. * New task class in place - now ready to implement the functionality. * Commit day's work. * Added form_alter hook to intercept submit on WebformMultiple task. * It works, next step some prettification. * Lint changes. * Fix notification by variable for part1 * Changed so that field names in source forms are prefixed with unique ID. * Remove composer update from CI check * Set composer update to get latest version per tag * Brushup before review. * Travis CI fix. * Remove tag versioning of forloeb module * Fix linting error. * Update README.md * Refactor unused webforms and flows * Add, install and configure r4032login module * Adjust description text * Rename template * Change category * Remove custom_theme and gin dependencies. The os2forms_forloeb module shouldn't make decisions about which theme to use. Leave that up to whichever install profile is being used. * Remove rules modules as dependency * lock to dev branch * Remove Forløb profile as a dependency * [#46780] Removed all parts of HK/Holstebro, to make the webform generic and reusable for everyone. * [#46800] Created new task-type for inheriting webform in flow * [#46800] adding returns after logs * [#46800] Adding all form fields to 'prepareTaskForSave' * Enable URL override for webform submissions and hashed url patterns (#93) * Enable URL override for webform submissions and hashed url patterns * Move pathauto.settings.yml to profile * [#46800] Added custom field to parent prepareTaskForSave method Co-authored-by: Carsten Agger <carstena@magenta-aps.dk> Co-authored-by: Carsten Agger <carstena@magenta.dk> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com> Co-authored-by: Carsten Agger <carstena@magenta-aps.dk> Co-authored-by: Carsten Agger <carstena@magenta.dk> Co-authored-by: Toke Fritzemeier <toke@magenta.dk> Co-authored-by: mb <mb@magenta-aps.dk> Co-authored-by: mBoegvald <36398987+mBoegvald@users.noreply.github.com>
…leaned logic of if-statement
…t_to_module [#46800] Adding MaestroWebformInherit to os2forms_forloeb.module
* Fix to bug on default purge setting not saving. * Better handling of submissions purge logic * Refactor and webform save error * Small change to purge logic * Remove save_webform check logic to always save changes. * Refactor upon review
lats1
approved these changes
Dec 9, 2021
Contributor
|
Hi mates. Is it possible to get #104 rin this PR too? |
Collaborator
Author
|
@andriyun It is possible. However we have to do a release for ITK for them to update thier instances. I Will gladly include it as it is part of the update to D9. So I will make the release and then await review on the update to webform auto exporter module. We have to stick to the current release procedure. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is approved we can make a new release from master branch.