Making HTML not get auto deleted#266
Merged
igor-ribeiiro merged 2 commits intoOfficeDev:masterfrom Apr 6, 2021
Merged
Conversation
igor-ribeiiro
force-pushed
the
html-deleted
branch
from
fc9e1c2 to
e25da33
Compare
akrantz
reviewed
Apr 5, 2021
| new CleanWebpackPlugin({ | ||
| cleanOnceBeforeBuildPatterns: dev ? [] : ["**/*"] | ||
| cleanOnceBeforeBuildPatterns: dev ? [] : ["**/*"], | ||
| cleanAfterEveryBuildPatterns: ["!**/*"] |
Contributor
There was a problem hiding this comment.
Should the cleanAfterEveryBuildPatterns be different between dev and prod? e.g. dev ? [!**/*] : []
Contributor
Author
There was a problem hiding this comment.
Sure, it makes sense to be that way if the prod is already working.
Just pushed this fix
akrantz
approved these changes
Apr 5, 2021
2 tasks
igor-ribeiiro
added a commit
that referenced
this pull request
Apr 12, 2021
* Fixing breakpoints for VSCode * Making HTML not get auto deleted (#266) Had to override the default behavior of the CleanWebpackPlugin. It normally deletes all files creates by other plugins that are not webpack. This is the case for out HTML, css and one .xml file. So I made it just clean the files before compiling and not after. Now you can run npm run build followed by npm start and the project would work. * Making it always wait the same amount (#267) Making test always wait 5000 regardless of flaky tests to make tests more reliable.
igor-ribeiiro
added a commit
that referenced
this pull request
Apr 12, 2021
* Fixing breakpoints for VSCode * Making HTML not get auto deleted (#266) Had to override the default behavior of the CleanWebpackPlugin. It normally deletes all files creates by other plugins that are not webpack. This is the case for out HTML, css and one .xml file. So I made it just clean the files before compiling and not after. Now you can run npm run build followed by npm start and the project would work. * Making it always wait the same amount (#267) Making test always wait 5000 regardless of flaky tests to make tests more reliable.
millerds
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Typo fixes "succesfully" -> "successfully" * FIx typo across all manifests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had to override the default behavior of the
CleanWebpackPlugin. It normally deletes all files creates by other plugins that are not webpack.This is the case for out HTML, css and one .xml file. So I made it just clean the files before compiling and not after.
Now you can run
npm run buildfollowed bynpm startand the project would work.