Making it always wait the same amount #267
Conversation
|
8 seconds is a really long time. Could it be smaller? I'm OK with increasing the value some if that is causing the tests to be flaky, but it would be nice if there was a reliable way to know when the function has returned. One way would be to use an Office.js event to know when the cell value was changed. A less elegant way would be to get the value in a loop until changed (or timed out). |
Yeah, just waiting around isn't the best, but it was the way it was being done already. A loop solution could give better times on success cases, but fail cases would be the same. |
|
How about we make it 5 seconds? That should be more than enough time for any platform. |
|
That's great to see that this fixes it. Also, I have added the enable-edge-webview artifact to our VM deployment script so we shouldn't hit the webivew hang problem moving forward |
Just did! |
igor-ribeiiro
merged commit dd7151c
into
OfficeDev:master
* Fixing breakpoints for VSCode * Making HTML not get auto deleted (#266) Had to override the default behavior of the CleanWebpackPlugin. It normally deletes all files creates by other plugins that are not webpack. This is the case for out HTML, css and one .xml file. So I made it just clean the files before compiling and not after. Now you can run npm run build followed by npm start and the project would work. * Making it always wait the same amount (#267) Making test always wait 5000 regardless of flaky tests to make tests more reliable.
* Fixing breakpoints for VSCode * Making HTML not get auto deleted (#266) Had to override the default behavior of the CleanWebpackPlugin. It normally deletes all files creates by other plugins that are not webpack. This is the case for out HTML, css and one .xml file. So I made it just clean the files before compiling and not after. Now you can run npm run build followed by npm start and the project would work. * Making it always wait the same amount (#267) Making test always wait 5000 regardless of flaky tests to make tests more reliable.
Making test always wait 8000 regardless of flaky tests to make tests more reliable.