perf: instrument MAP-NAV episode timings - #350
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finallyblocks around LLM, harvest, and control calls so failures and long waits are visible.Why
A production trace completed in 743.94 seconds: 45.492 seconds snapshot loading, 695.293 seconds MAP-NAV episode, and 0.494 seconds hydration. The aggregate episode timing did not identify the internal waits. These logs provide the next trace with a complete phase-level breakdown.
Validation
uv run ruff check packages/shared-python/shared/services/retrieval/nav/nav_agent.py packages/shared-python/shared/services/retrieval/nav/nav_llm.py packages/shared-python/shared/services/retrieval/nav/nav_orchestrate.pyuv run pytest apps/api/tests/contract/test_retrieval_mapnav_session_contract.py