Fetch request inline (single) example by gcatanese · Pull Request #15580 · OpenAPITools/openapi-generator

gcatanese · 2023-05-19T15:49:17Z

This PR makes the (single) request example available during the code generation. Currently only examples are fetched and available.

Fix #15579

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
In case you are adding a new generator, run the following additional script :
```
./bin/utils/ensure-up-to-date
```
Commit all changed files.
File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

* fix incomplete codegensecurity copies * refactoring

…nAPITools#15584)

* use docker * update * skip httpclient * update * sleep 120 * use cmd * restore tests * sleep 120 * clean up * skip

…ls#14126)" (OpenAPITools#15588) This reverts commit be9f1b6.

* update to jdk11, fix tests * update workflow to use jdk11 instead * update travis, circleci build * fix test failure, update CI * skip mvn install in appveyor * add windows tests * fix workflow * remove log level * add timeout * sleep more * skip tests * sleep more * only skip tests * test with jdk11 only * fix gradlew * remove skip tests * start server after build * update gradle version * more time to start server * update to 420 * comment out build * update * update

* update pom.xml with new plugin, setting * update workflow

…enAPITools#14296)

* set maven to 3.9 * add java version * fix maven version * fix java version

…do not use HttpBearerAuth (or HttpBasicAuth) for other http auth methods (such as http signature auth or custom schemes) (OpenAPITools#15220) * remove http signature from test yaml when not supported * do not use HttpBearerAuth for signature auth or other unsupported http auth method ignore unsupported http auth method unless generated code would not compile (in which case, an exception is thrown) * [Java] fix use of isBasic condition * [kotlin] fix use of isBasic condition

* better enforcer with gradle mgmt plugin * update gradle-enterprise * fix id

* removed .netcore 3.1 * dont use .net standard for test package

* Added library 'jvm-spring-webclient' to Kotlin client generator * Reran all generators and generated docs * Changed target of kotlin-jvm-spring-webclient sample from 2_0 to 3_0 * Added build of kotlin-jvm-spring-webclient to github workflow

…penAPITools#15608) * better code foramt, add library creator * remove kotlin server deprecated generator

Signed-off-by: Huan-Cheng Chang <changhc84@gmail.com>

* improved spacing * addressed comment

…nAPITools#15744)

wing328 · 2023-06-05T09:10:53Z

can you please resolve the merge conflicts when you've time?

wing328 · 2023-06-05T09:12:54Z

cc @OpenAPITools/generator-core-team

…ls#15687)

…ols#15751)

…/openapi-generator into request-inline-example # Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java

gcatanese · 2023-06-05T20:12:23Z

@wing328 Done

wing328 · 2023-06-15T08:52:48Z

this PR now contains commits not authored by you.

do you mind submitting a new PR based on the latest master instead?

gcatanese · 2023-06-15T17:09:15Z

@wing328 Please see #15857

gcatanese · 2023-06-16T06:08:58Z

Superseded by #15857

gcatanese and others added 30 commits May 19, 2023 17:37

Add (single) example

d9bd82a

Fetch single example when available

09c1378

[lua] fix use of isBasic condition (OpenAPITools#15529)

7443c95

[xojo] fix use of isBasic condition (OpenAPITools#15526)

2d8ec8b

[eiffel] fix use of isBasic condition (OpenAPITools#15533)

b754688

[android] fix use of isBasic condition (OpenAPITools#15528)

9d6f80a

[powershell] fix use of isBasic condition (OpenAPITools#15525)

b7a9373

[PHP] fix use of isBasic condition (OpenAPITools#15520)

7eeb7f6

[perl] fix use of isBasic condition (OpenAPITools#15524)

e83640c

[bash] fix use of isBasic condition (OpenAPITools#15521)

3e10c5d

[Ada] [Java] fix Codegen copies (OpenAPITools#15513)

89e4b24

* fix incomplete codegensecurity copies * refactoring

[cpp C++] fix use of isBasic condition (OpenAPITools#15535)

e7039f4

Fixed additional property omitGradleWrapper for kotlin generator (Ope…

08bb0f4

…nAPITools#15584)

Improve Appveyor tests (OpenAPITools#15585)

e758e4a

* use docker * update * skip httpclient * update * sleep 120 * use cmd * restore tests * sleep 120 * clean up * skip

Revert "fix#14119 property generateApis=false not working (OpenAPIToo…

6142315

…ls#14126)" (OpenAPITools#15588) This reverts commit be9f1b6.

Update pom.xml with new plugin, setting (OpenAPITools#15590)

5e800d9

* update pom.xml with new plugin, setting * update workflow

[Ktor] Update generator to latest Ktor version OpenAPITools#14061 (Op…

7881482

…enAPITools#14296)

Set maven to 3.9 in Github workflow (OpenAPITools#15592)

605cc7b

* set maven to 3.9 * add java version * fix maven version * fix java version

used default cancellation token (OpenAPITools#15594)

2af661d

remove fullJavaUtil (OpenAPITools#15033)

ad5cc82

[dart] fix use of isBasic condition (OpenAPITools#15523)

216e2c4

Update Enforcer (maven plugin) rule (OpenAPITools#15575)

273be46

* better enforcer with gradle mgmt plugin * update gradle-enterprise * fix id

[csharp-netcore] Removed .netcore 3.1 (OpenAPITools#15605)

5299935

* removed .netcore 3.1 * dont use .net standard for test package

[Kotlin] minor enhancements, remove KotlinServerDeprecatedGenerator (O…

833f649

…penAPITools#15608) * better code foramt, add library creator * remove kotlin server deprecated generator

[swift5] fix use of isBasic condition (OpenAPITools#15613)

f5903bc

fix variable name (OpenAPITools#15623)

1a483b2

Signed-off-by: Huan-Cheng Chang <changhc84@gmail.com>

[rust] fix use of isBasic condition (OpenAPITools#15532)

358397f

devhl-labs and others added 10 commits June 3, 2023 20:05

[csharp-netcore][generichost] Improved spacing (OpenAPITools#15740)

0943e50

* improved spacing * addressed comment

Fixed default for string query param (OpenAPITools#15686)

961b831

remove EOL in template file

7295c97

add a test case for python-fastapi query parameter default value (Ope…

fbb0d6d

…nAPITools#15744)

improved spacing (OpenAPITools#15741)

e5531c1

used name in camel case (OpenAPITools#15742)

3cff040

fixed more warnings and spacing issues (OpenAPITools#15743)

e06e2cc

fixed casing (OpenAPITools#15748)

4604bf0

used partial methods for logging (OpenAPITools#15749)

db3ef13

[PHP] fix security features listed in documentation (OpenAPITools#15750)

9bf7524

wing328 added Enhancement: Feature Feature: Generator labels Jun 5, 2023

wing328 added this to the 7.0.0 milestone Jun 5, 2023

tiffmaelite and others added 7 commits June 5, 2023 17:13

[C# csharp] fix security features listed in documentation (OpenAPIToo…

0d9ca8a

…ls#15687)

[TypeScript] fix security features listed in documentation (OpenAPITo…

d244601

…ols#15751)

support nullable check for OAS 3.1 (OpenAPITools#15698)

bc7bdca

Add (single) example

374499e

Fetch single example when available

4a32322

Add test

bf933ec

Merge branch 'request-inline-example' of https://github.com/gcatanese…

18c29b0

…/openapi-generator into request-inline-example # Conflicts: # modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultCodegenTest.java

gcatanese requested a review from jimschubert as a code owner June 5, 2023 19:45

gcatanese mentioned this pull request Jun 15, 2023

Fetch request inline (single) example (bis) #15857

Merged

6 tasks

gcatanese closed this Jun 16, 2023

gcatanese deleted the request-inline-example branch June 16, 2023 06:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fetch request inline (single) example#15580

Fetch request inline (single) example#15580
gcatanese wants to merge 126 commits intoOpenAPITools:masterfrom
gcatanese:request-inline-example

gcatanese commented May 19, 2023

Uh oh!

wing328 commented Jun 5, 2023

Uh oh!

wing328 commented Jun 5, 2023

Uh oh!

gcatanese commented Jun 5, 2023

Uh oh!

wing328 commented Jun 15, 2023

Uh oh!

gcatanese commented Jun 15, 2023

Uh oh!

gcatanese commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Conversation

gcatanese commented May 19, 2023

PR checklist

Uh oh!

wing328 commented Jun 5, 2023

Uh oh!

wing328 commented Jun 5, 2023

Uh oh!

gcatanese commented Jun 5, 2023

Uh oh!

wing328 commented Jun 15, 2023

Uh oh!

gcatanese commented Jun 15, 2023

Uh oh!

gcatanese commented Jun 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants