[Slim] Improve codebase decouple #438
Conversation
ybelenko
force-pushed
the
slim_enhancement_decouple
branch
2 times, most recently
from
6dd7aa6 to
81b5bc3
Compare
There was a problem hiding this comment.
+ apiPackage = invokerPackage + "\\" + apiDirName;
+ modelPackage = invokerPackage + "\\" + modelDirName;As the method name setInvokerPackage() implies, it should set only invokerPackage. 💡
There was a problem hiding this comment.
@ackintosh
I've copied it from PhpSymfony generator.
https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpSymfonyServerCodegen.java#L481-L490
Where I should place these changes then?
This enhancement required for modular testing and code coverage generating.
ybelenko
force-pushed
the
slim_enhancement_decouple
branch
from
81b5bc3 to
b7addcd
Compare
|
Fixed. |
ackintosh
left a comment
ackintosh
left a comment
There was a problem hiding this comment.
Thanks for the fix. Looks good to me.
Upgrade noteCurrent refactoring brings breaking changes. If your application stop working you need to copypaste endpoints implementation from |
|
The Shippable failure has been addressed in the master. |
* master: (116 commits) 3.1.0 release (OpenAPITools#486) Fix broken link to openapi generator plugin README (OpenAPITools#484) show warning message for nodejs server only (OpenAPITools#481) Add grokify to Go technical committee (OpenAPITools#479) [Slim] Improve codebase decouple (OpenAPITools#438) Ensure typescript samples are up to date (OpenAPITools#444) Update README.md [Golang][client] delete sample output dir before rebuild (OpenAPITools#477) update petstore samples (OpenAPITools#478) Revert "Improve Docker Tags (OpenAPITools#390)" update go client test dependencies (OpenAPITools#468) [Golang][client] fix for schema definition name `file` (OpenAPITools#433) Fix '.travis' file (syntax) make LICENSE GitHub display compatible (OpenAPITools#467) Improve Docker Tags (OpenAPITools#390) [Golang][client] fix file suffix for _test.go (OpenAPITools#449) Remove copy section (OpenAPITools#463) Add link to presentation (OpenAPITools#465) Use postProcessOperationsWithModels(Map, List) (OpenAPITools#431) [C] Adding petstore sample written in C (OpenAPITools#306) ...
* [Slim] Decouple Api files into separated PHP Classes This enhancement required for modular testing and code coverage generating. * [Slim] Define all app routes in SlimRouter PHP Class. Generate new samples
3 participants
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.1.x,4.0.x. Default:master.Description of the PR
Logical prepare before unit test generation feature.
Now generated package splitted into ApiControllers, Models and SlimRouter. This provides simple approach for unit testing and code coverage.
Samples omitted in first commit to simplify code review.
cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh