Berlin Group SCA redirect + consent form wording fix - #7
Merged
simonredfern merged 2 commits intoJul 15, 2026
Merged
Conversation
… flow Berlin Group authorises consents with a Consent-ID header rather than an OAuth token, so it has no code/id_token round-trip. On consent creation send TPP-Redirect-URI / TPP-Nok-Redirect-URI (OBP-API stores them in the consent JWT so Portal's SCA confirmation can send the browser back here), and redirect to the returned _links.scaRedirect URL instead of building an OIDC /auth URL; error out clearly if no scaRedirect is present. Fetch the consent info in the main display handler via the Consent-ID header, since the former fetch in the OAuth callback never ran for Berlin Group.
These forms only lodge the account-access consent (client_credentials, status AWAITINGAUTHORISATION/received) — the PSU has not authorised anything yet at this step. The actual grant happens later on the OIDC -> Portal SCA flow. Give Consent was misleading; the OBP consent form already used the correct Create Consent Request wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_links.scaRedirectSCA flow returned by OBP-API's create-consent response, instead of routing it through the OIDC authorization flow.AWAITINGAUTHORISATION/received) — the PSU hasn't authorised anything yet at this step. The actual grant happens later, on the OIDC -> Portal SCA flow. The OBP consent form already used the correct "Create Consent Request" wording.Test plan
mvn compile -o)