500 when deleting a source

[rkorytkowski]

Deletion of a source may end with 500 error due to broken data. The delete operation should succeed even if there are some data inconsistencies as a way to recover from a bad state.

Deletion should be done in a form of raw queries, which is much more performant and does not complain about bad state.

[paynejd]

FYI it appears that the DELETE operation is what actually broke the data in these 2 sources, because I had been using both sources prior to the delete. I'm wondering if it is the order of operations that is messed up -- it appears that some of the concepts were deleted before their corresponding mappings, because several of the mappings now have a to-concept of "None".

…

On Tue, Jun 5, 2018 at 8:41 AM Rafal Korytkowski ***@***.***> wrote: Deletion of a source may end with 500 error due to broken data. The delete operation should succeed even if there are some data inconsistencies as a way to recover from a bad state. Deletion should be done in a form of raw queries, which is much more performant and does not complain about bad state. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#54>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABInOXYW_ngfQIXatFjwez4dgt6FtIbmks5t5nx4gaJpZM4Uavxc> .

[rkorytkowski]

I see. I haven't investigated further, just rewritten the code in the proper way using faster queries. It's been already deployed to staging, so you can test it.

[paynejd]

Hey, I just tried deleting this source and received the error message in the image below:
https://staging.openconceptlab.org/orgs/DATIM-MOH-LS/sources/DATIM-Alignment-Indicators/

However, the delete did complete successfully and I was able to recreate an empty source with the same name. Not sure if the error was just lingering from the previously corrupted data, but looks like the fix worked!

[rkorytkowski]

I've checked the error and it is due to solr not being properly updated after executing raw queries. I need to trigger solr removal as well. I'll do a follow up commit.

[paynejd]

Ah, that makes sense! Glad you found this one...

…

On Wed, Jun 6, 2018 at 6:51 AM Rafal Korytkowski ***@***.***> wrote: I've checked the error and it is due to solr not being properly updated after executing raw queries. I need to trigger solr removal as well. I'll do a follow up commit. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABInOXF4zoCcDw_OF5Zqp_Gb8oc5vEKJks5t57OGgaJpZM4Uavxc> .

[rkorytkowski]

Needed to revert it in OpenConceptLab/oclapi@45d6cab due to failing tests. I'll work on a proper fix.