Fix RPC response validation and topic reallocation churn#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cy_respond()argument validation so malformed NULL-data/nonzero-size payloads and invalid breadcrumb priorities are rejected before platform unicast, without advancing the response sequence number.topic_allocate()changes eviction count but maps back to the same subject-ID, while leaving subject moves, displacement handling, gossip scheduling, and diagnostics semantics intact.todo/resolved/.Branch commits
62eea1dFix cy_respond argument validation0d29e96Fix same-subject topic reallocation churnVerification
cmake --build build-l17 --parallel --target test_intrusive_topic_allocation_x64_c11 test_intrusive_topic_allocate_exhaustive_x64_c11ctest --test-dir build-l17 -R 'run_test_intrusive_topic_(allocation|allocate_exhaustive)_x64_c11' --output-on-failurecmake --build build-l17 --parallelctest --test-dir build-l17 --output-on-failure(105/105 passed)git diff --check origin/main..devadded_comment_lines=9 removed_comment_lines=11