Fix DSDL Compiler Dynamic Array Encoding/Decoding Issues #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In using dynamic arrays in my project, I came across a major issue where the first two elements in an array would be decoded correctly, but any element after that was mangled and useless.
After a few hours of debugging, (and some major help from some friends) we traced it back to the DSDLC-generated decode_internal functions.
Essentially, we found that the loop that decodes each element in the array adds the value returned by the decode_internal function of the internal data structure, which returns the cumulative offset expands way too fast. The offset value is essentially added to itself and the incremented value each time, which means that new elements are essentially placed in arbitrary memory locations.
The encode fix hasn't been entirely tested, but looking at the code it follows with the same logical error as the decoding issue, and changing the += to = fixed the issue entirely in decoding.