Fixing CI - Compiling GDAL for non-windows - #1995
Conversation
1cb6269 to
4ecc3b0
Compare
- GDAL is not compiled for non-windows machines (linux/mac). + Added gdal to superbuild. + Updated dependencies in snapcraft. + Set cmake dependencies for Gdal. + Added dummy cmake target for Win setup. - Downgraded CUDA Docker to 12.x (13.0 removed required headers).
4ecc3b0 to
86984de
Compare
| - python3-numpy | ||
| - python3-setuptools | ||
| - swig | ||
| stage-packages: - libcurl3t64-gnutls - libgeotiff5 |
There was a problem hiding this comment.
Small formatting issue? I don't think we test with the snapcraft.yaml and use snapcraft24.yaml
There was a problem hiding this comment.
Good catch, fixing it.
In general, I am a bit puzzled about the whole snapcraft thing. It would seem that it is only used to pull the dependencies during configure.sh, and in our CI only Ubuntu 24.04 is used...
There was a problem hiding this comment.
Me too! 😆
I guess its useful for anyone wishing to use snap, but my personal preference would be Debian base images and apt packages defined in the Dockerfile
There was a problem hiding this comment.
You can/should remove the snapcraft stuff if you get a chance. The project used to have snap packaging support, but that's no longer the case.
| ### Use a second image for the final asset to reduce the number and | ||
| # size of the layers. | ||
| FROM nvidia/cuda:13.0.0-devel-ubuntu24.04 | ||
| FROM nvidia/cuda:12.9.1-devel-ubuntu24.04 |
There was a problem hiding this comment.
I wonder if we can save a bit of space using the nvidia/cuda:12.9.1-runtime-ubuntu24.04 image instead of devel here
| # Env variables | ||
| ENV DEBIAN_FRONTEND=noninteractive \ | ||
| PYTHONPATH="$PYTHONPATH:/code/SuperBuild/install/lib/python3.12/dist-packages:/code/SuperBuild/install/bin/opensfm" \ | ||
| PYTHONPATH="$PYTHONPATH:/code/SuperBuild/install/local/lib/python3.12/dist-packages:/code/SuperBuild/install/lib/python3.12/dist-packages:/code/SuperBuild/install/bin/opensfm" \ |
There was a problem hiding this comment.
Does the standard Dockerfile need to also be updated to use local/lib/python3.12/dist-packages too (now that GDAL goes there)?
Looks like:
gdal --> /code/SuperBuild/install/local/lib/python3.12/dist-packages
pdal --> /code/SuperBuild/install/lib/python3.12/dist-packages
opensfm --> /code/SuperBuild/install/bin
There was a problem hiding this comment.
Probably, I actually forgot about that one. Let me dig around.
- Fixing format for snapcraft.yaml - Swapping GPU image for runtime - Fixing standard dockerfile runpath
| - python3-setuptools | ||
| - swig | ||
| stage-packages: | ||
| - libcurl3t64-gnutls - libgeotiff5 |
There was a problem hiding this comment.
Sorry to be a pain - seems like one was missed!
I wonder if snapcraft is smart enough to still parse the yaml despite the syntax issue
3 participants
No description provided.