Skip to content

Installing python dependencies last - #1997

Merged
DodgySpaniard merged 2 commits into
masterfrom
fix-python-dendencies-order
Mar 10, 2026
Merged

Installing python dependencies last#1997
DodgySpaniard merged 2 commits into
masterfrom
fix-python-dendencies-order

Conversation

@DodgySpaniard

Copy link
Copy Markdown
Member

Python dependencies (throug PIP) require gdal, moving python install after superbuild. Keeping Numpy (to compile opnecv).

Python dependencies (throug PIP) require gdal, moving python install
after superbuild. Keeping Numpy (to compile opnecv).
@DodgySpaniard

Copy link
Copy Markdown
Member Author

Tested on ARM build: buildx build --file portable.Dockerfile --platform linux/arm64

@DodgySpaniard
DodgySpaniard marked this pull request as ready for review March 9, 2026 06:29

@spwoodcock spwoodcock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@smathermather

smathermather commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Maybe an extant bug from #1995, PDAL needs GEOS support or else split merge breaks as PDAL cannot generate the hexbin-based boundary:

pdal info --boundary --filters.hexbin.edge_length=1 --filters.hexbin.threshold=1 "/datasets/code/submodels/submodel_0000/odm_georeferencing/odm_georeferenced_model
.decimated.las" > "/datasets/code/submodels/submodel_0000/odm_georeferencing/odm_georeferenced_model.boundary.json"
PDAL: PDAL must be using a version of GDAL built with GEOS support to use this function.

[WARNING] Cannot calculate crop bounds! We will skip cropping!

Otherwise, I don't see any issues.

To replicate, download Brighton Beach, then run with the following options: --split 8 --split-overlap 20.

Added GEOS and XPAT libraries, gdal cmake adds them by default if
available in the system.
@DodgySpaniard

Copy link
Copy Markdown
Member Author

I added the dependencies geos and expat to the system. GDAL CMake uses find_package and uses them by default if found.

As a side note, it is a good gotcha using the split settings, taking notes as we need to define a test process for releases.

@DodgySpaniard
DodgySpaniard merged commit 99ddf29 into master Mar 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants