Skip to content

Avoid global write lock on every delete in GroupManager #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vharseko wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid global write lock on every delete in GroupManager #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion opendj-server-legacy/src/main/java/org/opends/server/core/GroupManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* Copyright 2007-2010 Sun Microsystems, Inc.
* Portions Copyright 2011-2016 ForgeRock AS.
* Portions Copyright 2025 3A Systems,LLC.
* Portions Copyright 2025-2026 3A Systems,LLC.
*/
package org.opends.server.core;

Expand Down Expand Up @@ -678,6 +678,23 @@ private void doPostDelete(PluginOperation deleteOperation, Entry entry)
return;
}

// Fast path: this hook runs for every delete, but almost no deleted
// entries have a group registered at or below them. Check with the read
// lock first instead of serializing all delete threads on the exclusive
// lock (same pattern as SubentryManager.doPostDelete).
lock.readLock().lock();
try
{
if (!groupInstances.containsSubtree(entry.getName()))
{
return;
}
}
finally
{
lock.readLock().unlock();
}

lock.writeLock().lock();
try
{
Expand Down