convert_README_to_header.sh doesn't escape double-quotes in README.md file

[Lotharyx]

Double-quotes in a README.md file will lead to broken code in the WhateverPluginDescription.h file because they do not get escaped.

The fix is to modify the call to sed as follows:

# See http://stackoverflow.com/a/16576291
# On Mac OS's sed, \n is not recognized as a newline character, but
# \[actual newline] works
desc=`sed -e ':a' -e 'N' -e '$!ba' -e 's/\"/\\\"/g' -e 's/\n/\\\\n"\\
"/g' "$path/README.md"`;

The change is the addition of -e 's/\"/\\\"/g' argument.

I hit this writing a plugin that has no use outside my very specific scenario (involving hardware I built) so I just figured I'd report it here rather than going to the trouble of forking and submitting a pull request for a handful of characters in a single file; I hope that's okay.

[peternewman]

Hi @Lotharyx ,

Well spotted. You could always open source your hardware; there's always room for another USB dongle 😄 !

You can do the fork entirely on the GitHub website if you want, which gives you the credit, but if you'd rather not, or aren't really bothered, we can indeed take the fix from here.

[Lotharyx]

Hello Peter, I’m not bothered about getting credit for this, so please go ahead and take the fix from here. Cheers!

…

On Sep 10, 2018, at 4:57 AM, Peter Newman ***@***.***> wrote: Hi @Lotharyx , Well spotted. You could always open source your hardware; there's always room for another USB dongle 😄 ! You can do the fork entirely on the GitHub website if you want, which gives you the credit, but if you'd rather not, or aren't really bothered, we can indeed take the fix from here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.