Initial Pychecker for OLA work - #1000
Merged
Merged
Conversation
Optimise the code slightly too
Member
Author
There was a problem hiding this comment.
I've not tested this, but I believe I've got the syntax right.
Member
|
Resync please so this doesn't have all the ArtNet / E1.31 changes. |
Merge pull request OpenLightingProject#999 from peternewman/libusb
Member
Author
|
This is down to where I branched from and will be resolved by #1001 . |
Member
|
LGTM |
Member
Author
There was a problem hiding this comment.
Are the changes here and below okay @nomis52 , before I apply them to the other files and we can start getting some of this merged in?
Member
|
LGTM so far |
Member
Author
|
Okay @nomis52 I think this chunk can go in if you're happy. |
Member
Author
|
This is just failing due to http://llvm.org/apt/llvm-snapshot.gpg.key . |
Member
Author
|
Now back and working. |
Member
Author
|
Merge @nomis52 ? |
nomis52
added a commit
that referenced
this pull request
Jan 10, 2016
Initial Pychecker for OLA work
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.