Adds support for AVLdiy.cn D512 usb dmx device, closes #1073 by thgjerde · Pull Request #1134 · OpenLightingProject/ola

thgjerde · 2016-10-03T19:00:18Z

The AVLdiy.cn D512 uses the same protocol as the Anyma uDMX device.

peternewman

Some lint issues for starters.

I'm wondering if you can sensibly subclass some of the Anyma uDMX classes, or if it's worth it.

peternewman · 2016-10-04T02:37:50Z

+   * @param serial the serial number of the widget.
+   */
+  AVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+            libusb_device *usb_device,


Indent by one to match the (

peternewman · 2016-10-04T02:38:18Z

+   */
+  AVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+            libusb_device *usb_device,
+            const std::string &serial)


Indent by one to match the (

peternewman · 2016-10-04T02:38:34Z

+   * @param serial the serial number of the widget.
+   */
+  SynchronousAVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+                       libusb_device *usb_device,


Indent by one to match the (

peternewman · 2016-10-04T02:38:39Z

+   */
+  SynchronousAVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+                       libusb_device *usb_device,
+                       const std::string &serial);


Indent by one to match the (

peternewman · 2016-10-04T02:38:50Z

+   * @param serial the serial number of the widget.
+   */
+  AsynchronousAVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+                        libusb_device *usb_device,


Indent by one to match the (

peternewman · 2016-10-04T02:38:54Z

+   */
+  AsynchronousAVLdiyD512(ola::usb::LibUsbAdaptor *adaptor,
+                        libusb_device *usb_device,
+                        const std::string &serial);


Indent by one to match the (

peternewman · 2016-10-04T02:42:37Z

 # udev rules for the anyma dmx device
 SUBSYSTEM=="usb|usb_device", ACTION=="add", ATTRS{idVendor}=="16c0", ATTRS{idProduct}=="05dc", GROUP="plugdev"

+# udev rules for the avldiy dmx device


Can you also open a PR here to patch the pi file: https://github.com/OpenLightingProject/raspberrypi/blob/master/etc/udev/rules.d/10-local.rules

OpenLightingProject/raspberrypi#8

peternewman · 2016-10-04T02:43:04Z

+ *
+ * AVLdiyD512.cpp
+ * The synchronous and asynchronous AVLdiy D512 widgets.
+ * Copyright (C) 2014 Simon Newton


Correct this to your name and 2016.

peternewman · 2016-10-04T02:43:16Z

+ *
+ * AVLdiyD512.h
+ * The synchronous and asynchronous AVLdiy D512 widgets.
+ * Copyright (C) 2014 Simon Newton


Correct this to your name and 2016.

peternewman · 2016-10-04T02:43:32Z

+ *
+ * AVLdiyD512Factory.cpp
+ * The factory for AVLdiy D512 widgets.
+ * Copyright (C) 2014 Simon Newton


Correct this to your name and 2016.

peternewman · 2016-10-04T02:43:37Z

+ *
+ * AVLdiyD512Factory.h
+ * The factory for AVLdiy D512 widgets.
+ * Copyright (C) 2014 Simon Newton


Correct this to your name and 2016.

peternewman · 2016-10-07T16:37:20Z

If you resync @thgjerde the Mac tests should now pass.

peternewman · 2016-10-07T16:47:29Z

This will close #1073 .

The AVLdiy.cn D512 uses the same protocol as the Anyma uDMX device.

thgjerde · 2016-10-08T09:53:37Z

I don't see an easy way to inherit from the AnymauDMX classes without refactoring all of the SimpleWidget inheritance tree.

peternewman · 2016-10-08T10:38:00Z

Okay, I'd not really looked, just throwing it out there.

Can you avoid squashing in future please, as it makes my job harder to see if you've fixed the comments.

peternewman · 2016-10-09T13:04:18Z

Can you also add a mention of your interface to: https://github.com/OpenLightingProject/ola/blob/master/plugins/usbdmx/UsbDmxPlugin.cpp#L95

You may also want to add yourself here:
https://github.com/OpenLightingProject/ola/blob/master/AUTHORS

peternewman

Just a few final bits from me.

peternewman · 2016-10-09T13:18:30Z

+};
+
+bool AVLdiyThreadedSender::TransmitBuffer(libusb_device_handle *handle,
+                                         const DmxBuffer &buffer) {


Indent by one to match the (

peternewman · 2016-10-09T13:26:57Z

  return true;
 }

+bool SyncPluginImpl::NewWidget(AVLdiyD512 *widget) {


Can you put this below the AnymauDMX method.

peternewman · 2016-10-09T13:27:26Z

      m_debug_level(debug_level),
      m_preferences(preferences),
      m_context(NULL) {
+  m_widget_factories.push_back(new AVLdiyD512Factory(&m_usb_adaptor));


Can you put this below the AnymauDMX method.

peternewman · 2016-10-09T13:30:03Z

Aside from my final comments, anything else from yourself @nomis52 ?

thgjerde · 2016-10-12T19:32:20Z

I think I have addressed all the requested changes.

thgjerde · 2016-10-16T18:05:17Z

Please let me know if there is anything more I should fix.

peternewman · 2016-10-17T17:06:00Z

Thanks @thgjerde , sorry I've been away, I'll take a proper look tonight and should be able to merge them from the looks of things.

peternewman · 2016-10-18T02:53:18Z

LGTM

peternewman self-assigned this Oct 4, 2016

peternewman added this to the 0.11.0 milestone Oct 4, 2016

peternewman requested changes Oct 4, 2016

View reviewed changes

peternewman reviewed Oct 4, 2016

View reviewed changes

peternewman changed the title ~~Adds support for AVLdiy.cn D512 usb dmx device~~ Adds support for AVLdiy.cn D512 usb dmx device, closes #1073 Oct 7, 2016

Adds support for AVLdiy.cn D512 usb dmx device

5e86b86

The AVLdiy.cn D512 uses the same protocol as the Anyma uDMX device.

thgjerde force-pushed the master branch from f677bca to 5e86b86 Compare October 8, 2016 09:02

peternewman requested changes Oct 9, 2016

View reviewed changes

peternewman assigned nomis52 Oct 9, 2016

Cleanup for AVLdiy D512 support.

982af62

nomis52 approved these changes Oct 11, 2016

View reviewed changes

peternewman approved these changes Oct 18, 2016

View reviewed changes

peternewman merged commit 35fda2d into OpenLightingProject:master Oct 18, 2016

peternewman referenced this pull request in nip3o/open-lighting Jun 7, 2018

Hacked stuff to work with AVLdiy uDMX devices

e3b792f

peternewman mentioned this pull request Jul 12, 2026

Add 0.11 news #2060

Draft

Uh oh!

Conversation

thgjerde commented Oct 3, 2016

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

peternewman Oct 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peternewman commented Oct 7, 2016

Uh oh!

peternewman commented Oct 7, 2016

Uh oh!

thgjerde commented Oct 8, 2016

Uh oh!

peternewman commented Oct 8, 2016

Uh oh!

peternewman commented Oct 9, 2016

Uh oh!

peternewman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peternewman Oct 4, 2016 •

edited

Loading