More RDM test changes - #1277
Merged
peternewman merged 10 commits intoAug 13, 2017
Merged
Conversation
Member
Author
|
Sorry, this one is rather large but I only did it as two commits before. |
(cherry picked from commit 802ee55)
Member
Author
|
Hopefully this is small enough to review now as a single standalone PR @nomis52 ? I don't think I can really break it down further (while still passing the tests), unless I go and make some fresh commits to do the same code changes, as I did it in a few big chunks as it was mostly copying and pasting from the RDM test generation script output. |
Merged
Merged
Member
Author
|
Is this small enough on it's own now @nomis52 ? There's a tiny bit more I could pull out if it helps, but most of this is now just moving some of the tests from one bit of the file to another so they're grouped together. |
nomis52
approved these changes
Aug 13, 2017
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1196 .