Make all plugins CamelCase - #1286
Conversation
|
d245842 actually makes it standard Markdown compliant which enabled me to preview it right in my editor which doesn't understand GFM. I'm rather confused why the line breaks worked before, since GFM does also require 2 spaces at the end of a line. It shouldn't break things though. |
peternewman
left a comment
There was a problem hiding this comment.
Hi @FloEdelmann sorry for messing you about, but having had a ponder and talked to @nomis52 , our codebase capitalises acronyms, rather than camel casing them (e.g. https://github.com/OpenLightingProject/ola/blob/master/include/ola/network/TCPSocket.h and https://github.com/OpenLightingProject/ola/blob/master/include/ola/rdm/RDMAPI.h ) so would you mind reverting this please. If you're still feeling keen, it's actually UARTDMX, USBDMX, USBPro, FTDIDMX and OpenDMX that want updating.
Regarding GFM/MD and d245842 , can you do that in a separate PR for discussion, but my feeling is the link bit shouldn't be tweaked, I deliberately went for GFM so it renders best in GitHub along with the code (but can also be rendered fine in the UIs).
|
Well, then UARTDMX, USBDMX, USBPro, FTDIDMX and OpenDMX can all be done in a separate pull request and this one can be closed. I'll raise an issue for that. |
|
Thanks again @FloEdelmann and sorry for the change of mind. |
As discussed in #1285, I refactored the SPI plugin to change the C++ name prefix to
Spi. To standardize all plugins, I did the same for the GPIO, OPC and OSC plugins.Unfortunately, I get the following errors when
makeing, although I cannot find references to the old names in the code anymore:Am I missing something or are these old build artefacts and I just have to rebuild completely (I have already run
make clean)?