Fix some more RDM tests - #1305
Merged
peternewman merged 4 commits intoAug 20, 2017
Merged
Conversation
(cherry picked from commit 027e693)
nomis52
reviewed
Aug 15, 2017
| self.NackSetResult(RDMNack.NR_FORMAT_ERROR), | ||
| # TODO(Peter): Fix this, ideally we change behaviour based on past | ||
| # support of the PID | ||
| self.NackSetResult(RDMNack.NR_UNSUPPORTED_COMMAND_CLASS), |
Member
Author
There was a problem hiding this comment.
Think of e.g device hours, a responder may not support setting it, in which case this response is valid, depending on the order packet format and command class are checked.
The future extension is to remember if we succeeded on a normal SetDeviceHours, pass that in and advisory/warn here that the normal one succeeded and this didn't fail with NR_FORMAT_ERROR.
I can add a warning/advisory to these in the interim saying this should really be an NR_FORMAT_ERROR if you'd like, but I don't think that's correct if SET isn't supported generally for the PID.
Member
Author
There was a problem hiding this comment.
Are you happy with that as an explanation @nomis52, or do we need a different plan going forward?
nomis52
approved these changes
Aug 19, 2017
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 027e693)