Initialize members of SPIDMXParser class - #1329
Merged
Merged
Conversation
nomis52
requested changes
Nov 20, 2017
| SPIDMXParser(DmxBuffer *buffer, Callback0<void> *callback) | ||
| : m_dmx_buffer(buffer), | ||
| m_callback(callback) { | ||
| state = WAIT_FOR_BREAK; // reset in ChangeState() |
Member
There was a problem hiding this comment.
These should all be prefixes with m_ and set using m_state(WAIT_FOR_BREAK)
Member
|
If you're interested @FloEdelmann , there's details on Coverity Scan here: You can sign up, run it on your own machine, and upload the results to the website for analysis. Or you could configure your own Travis instance to run it with your key. |
nomis52
approved these changes
Dec 18, 2017
peternewman
requested changes
Dec 19, 2017
peternewman
left a comment
peternewman
left a comment
Member
There was a problem hiding this comment.
@FloEdelmann , Travis is now complaining:
https://travis-ci.org/OpenLightingProject/ola/jobs/318397996#L3314
The class constructor needs to match the order of the variable in the code:
https://stackoverflow.com/questions/1564937/gcc-warning-will-be-initialized-after
peternewman
approved these changes
Dec 24, 2017
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addition to #1289, as requested in a comment after merging.
I don't know how to run Coverity myself, so I initialized all members. It builds without problems and all variables are reset before first proper use anyway, so it should not break anything.