Fix more spelling errors - #1353
Merged
peternewman merged 3 commits intoJan 4, 2018
Merged
Conversation
nomis52
approved these changes
Jan 4, 2018
FloEdelmann
reviewed
Jan 5, 2018
| IPV4Address m_localhost; | ||
| ola::SingleUseCallback0<void> *m_timeout_closure; | ||
| unsigned int m_sucessfull_calls; | ||
| unsigned int m_sucessful_calls; |
Member
There was a problem hiding this comment.
shouldn't it be m_successful_calls, i.e. 2 cs? This is not yet covered by #1355 (although it's the same spelling mistake).
Member
Author
There was a problem hiding this comment.
Well spotted @FloEdelmann . I think when #1360 is in, I'll have found all variants of suc+es+ful+ , some fixed in master, and some in 0.10. It now finds words within underscores, so should catch that sort of thing in future. CamelCase and camelCase still need resolving if anyone fancies a python regex challenge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the latest codespell and improve the regex to help find them