Skip to content

Add link to my Bachelor's Thesis in SPI DMX Plugin's README - #1369

Merged
peternewman merged 2 commits into
OpenLightingProject:masterfrom
FloEdelmann:spidmx-bachelor
Feb 6, 2018
Merged

Add link to my Bachelor's Thesis in SPI DMX Plugin's README#1369
peternewman merged 2 commits into
OpenLightingProject:masterfrom
FloEdelmann:spidmx-bachelor

Conversation

@FloEdelmann

Copy link
Copy Markdown
Member

The online version of my Bachelor's Thesis is finally available!

I've documented the whole development process of a PC-DMX interface using OLA, including my implementation of the SPI DMX Plugin and a corresponding electrical schematic. Thus, I think it will be a useful resource to add to the plugin's README.

Maybe you want to look into it @peternewman and @nomis52 :)

@peternewman peternewman added this to the 0.11.0 milestone Jan 31, 2018

@peternewman peternewman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor grammar nit.

Comment thread plugins/spidmx/README.md Outdated
channels (which results in more stuttering in all channels, as the time
between two SPI read operation increases).

A detailed description of the development process and the used techniques

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, grammar wise, it should probably be the techniques used.

@peternewman
peternewman requested a review from nomis52 January 31, 2018 19:04
@peternewman

Copy link
Copy Markdown
Member

An interesting read too @FloEdelmann , thanks for that.

Another possible extension, which probably ought to be fairly simple given all the leg work you've done already would be to create another RDM/DMX sniffer like the logic one:
https://github.com/OpenLightingProject/ola/tree/master/tools/logic

Which essentially just tries to decode and print whatever data you've received. I guess missing the top of some frames may make it somewhat less helpful for RDM though...

@FloEdelmann

Copy link
Copy Markdown
Member Author

Good that the thesis itself was proof-read several times 😃

Yeah, I already thought receiving RDM with this plugin. However, I came to the same conclusion as you did: For DMX, missing a packet is not too bad because it will be sent again later. RDM packets have to be received correctly at the first try though, which is quite unlikely (given that the whole packet needs to fit into one chunk).

So I think it won't be too useful.

@peternewman
peternewman merged commit 5dbf4b5 into OpenLightingProject:master Feb 6, 2018
peternewman added a commit to peternewman/ola that referenced this pull request Dec 10, 2018
peternewman added a commit that referenced this pull request Dec 11, 2018
More optimised fix for #1369, which tries to be smarter and avoid the problem UID
@peternewman peternewman mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants