Rename ArtNet, Artnet, artnet, Art-net to Art-Net - #1405
Conversation
In all comments, strings and documentation. Closes OpenLightingProject#1328
|
Amazing thanks @nils-van-zuijlen |
| } else { | ||
| OLA_WARN << "ArtNet RDM request failed with code " << reply->StatusCode(); | ||
| OLA_WARN << "Art-Net RDM request failed with code " | ||
| << reply->StatusCode(); |
There was a problem hiding this comment.
You've somehow inserted a Unicode character in here according to the compiler errors.
There was a problem hiding this comment.
Yes, it was an non-breaking space instead of a regular space.
Which prevented proper compiling
|
The travis build failed because of this commit in codespell #1407 should be merged in order to fix this. |
peternewman
left a comment
peternewman
left a comment
There was a problem hiding this comment.
Just a few minor nits @nils-van-zuijlen . Otherwise LGTM.
| * Add an option for using the limited broadcast address for ArtNet dmx data | ||
| * Fixed Art-Net RDM discovery so DMXWorkshop works correctly - #160 | ||
| * Fixed a memory leak in the Art-Net RDM implementation | ||
| * Add an option for using the limited broadcast address for Art-Net dmx data |
There was a problem hiding this comment.
Nit, and not your fault, but could we change dmx to DMX here please.
| label { | ||
| value: 1 | ||
| label: "ArtNet" | ||
| label: "Art-Net" |
There was a problem hiding this comment.
These also want updating here, which is where this data is sourced from if you're feeling keen: https://github.com/OpenLightingProject/rdm-app/blob/master/data/pid_data.py#L719
| // the universe address has changed we need to drop this request | ||
| OLA_WARN << "ArtNet Output port has changed mid request, dropping response"; | ||
| OLA_WARN << "Art-Net Output port has changed mid request, " | ||
| <<"dropping response"; |
There was a problem hiding this comment.
Can we have a space after << please. Also we'd generally just move the one word that doesn't fit down (i.e. response in this case).
11340a4 to
8995ae3
Compare
| * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * E131ConfigMessages.proto | ||
| * Defines the protocol buffers used to configure the Artnet device |
There was a problem hiding this comment.
@nils-van-zuijlen Sorry I've just spotted, do you fancy opening a new PR to correct this to E1.31 as it's actually a copy/paste error from then?
There was a problem hiding this comment.
But isn't it the filename ?
There was a problem hiding this comment.
Yes, the first one should be. I meant line 17 where it talks about using E131ConfigMessages.proto to configure the 'Artnet' device!
In plugins/e131/messages/E131ConfigMessages.proto As requested [there](OpenLightingProject#1405 (review)).
In plugins/e131/messages/E131ConfigMessages.proto:17 And libs/acn/E131InflatorTest.cpp:155 As requested there: OpenLightingProject#1405 (review)
3 participants
In all comments, strings and documentation.
#1328