Skip to content

Fix allowed failures on Travis - #1622

Merged
peternewman merged 3 commits into
OpenLightingProject:masterfrom
peternewman:travis-mac
Mar 19, 2020
Merged

Fix allowed failures on Travis#1622
peternewman merged 3 commits into
OpenLightingProject:masterfrom
peternewman:travis-mac

Conversation

@peternewman

Copy link
Copy Markdown
Member

No description provided.

@peternewman peternewman added this to the 0.11.0 milestone Mar 19, 2020

@kripton kripton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "default" version of Python instead of 2.x? Looks good to me :D
However, one test on Travis still failing: https://travis-ci.org/github/OpenLightingProject/ola/jobs/664195928#L14569

@peternewman

Copy link
Copy Markdown
Member Author

Using "default" version of Python instead of 2.x? Looks good to me :D

It's more the subtlety of them changing exactly how allowed_failures works.

However, one test on Travis still failing: https://travis-ci.org/github/OpenLightingProject/ola/jobs/664195928#L14569

That's just a flaky OS X test:
https://travis-ci.org/github/OpenLightingProject/ola/jobs/664195928#L14569

@peternewman peternewman changed the title Try and fix allowed failures Fix allowed failures on Travis Mar 19, 2020
@peternewman
peternewman merged commit 1045b59 into OpenLightingProject:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants