Skip to content

Set a default value for the enabling Eurolite Mk2 preference - #1717

Merged
peternewman merged 2 commits into
masterfrom
peternewman-eurolite-mk2-default-pref
Mar 16, 2021
Merged

Set a default value for the enabling Eurolite Mk2 preference#1717
peternewman merged 2 commits into
masterfrom
peternewman-eurolite-mk2-default-pref

Conversation

@peternewman

Copy link
Copy Markdown
Member

CC @ridicolos and @aroffringa

This sets a default value (of false) for enable_eurolite_mk2 and writes it into the relevant conf file making things easier for the user.

Sorry @aroffringa I'm not sure why I didn't suggest this before.

@peternewman peternewman added this to the 0.11.0 milestone Mar 2, 2021
@ridicolos

Copy link
Copy Markdown

Hey @peternewman, I will test this feature in the course of the week. I will give you an update then.

@peternewman

Copy link
Copy Markdown
Member Author

Hey @peternewman, I will test this feature in the course of the week. I will give you an update then.

Thanks @ridicolos . There's really no reason it should fail, and I've confirmed it generates the default false option correctly, but not having the hardware it would be nice to know I haven't somehow broken that.

@ridicolos

Copy link
Copy Markdown

@peternewman so on friday the date is set. There I can test the whole thing. The last few days I have unfortunately not got my hands on the hardware.

@peternewman

Copy link
Copy Markdown
Member Author

@peternewman so on friday the date is set. There I can test the whole thing. The last few days I have unfortunately not got my hands on the hardware.

Thanks @ridicolos , no huge rush, Friday is fine!

@ridicolos

ridicolos commented Mar 12, 2021

Copy link
Copy Markdown

@peternewman So I tried it now. I installed OLA from scratch with this branch.

After I ran olad I checked the ola-usbdmx.conf. It was set to enable_eurolite_mk2 = false. I deleted that line, started olad again and it immediately added the line with false again.

olad -l 4 gave the following output:

plugins/usbdmx/EuroliteProFactory.cpp:107: Connected FTDI device could be a Eurolite USB-DMX512-PRO MK2 but was ignored, because enable_eurolite_mk2 was false.

If I set it to true manually in the config it works.

The rest of the output you can check here: https://pastebin.com/wPDSXgpf

@peternewman

Copy link
Copy Markdown
Member Author

If I set it to true manually in the config it works.

Perfect thanks. I'd done the other basic tests myself, but it's always reassuring to know it hasn't somehow broken the support for the device in some weird way, I'll get this merged now.

@peternewman peternewman assigned peternewman and unassigned ridicolos Mar 16, 2021
@peternewman
peternewman merged commit 920cac2 into master Mar 16, 2021
@peternewman
peternewman deleted the peternewman-eurolite-mk2-default-pref branch April 20, 2021 00:04
@peternewman peternewman mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants