Skip to content

Add a helper method to convert an RDMResponse to a NACKing RDMResponse - #1828

Merged
kripton merged 1 commit into
OpenLightingProject:masterfrom
peternewman:rdm-test-generation
Mar 8, 2023
Merged

Add a helper method to convert an RDMResponse to a NACKing RDMResponse#1828
kripton merged 1 commit into
OpenLightingProject:masterfrom
peternewman:rdm-test-generation

Conversation

@peternewman

Copy link
Copy Markdown
Member

(cherry picked from commit 324b4ec)

@peternewman peternewman added this to the 0.11.0 milestone Mar 5, 2023
@peternewman
peternewman requested a review from kripton March 5, 2023 19:49
@peternewman

Copy link
Copy Markdown
Member Author

Ping @kripton in case you missed it...

@kripton kripton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good, new test case PASSes on my machine and FAILs if I modify it (just to make sure it was actually run)

@kripton
kripton force-pushed the rdm-test-generation branch from 85da9e8 to ca5d405 Compare March 8, 2023 20:51
@kripton

kripton commented Mar 8, 2023

Copy link
Copy Markdown
Member

@peternewman: Interesting, even though the branch is in your repo, I was able to rebase it on top of latest master using GitHub's web interface. I'll merge it as soon as all CI checks are green.

@kripton
kripton merged commit e12f306 into OpenLightingProject:master Mar 8, 2023
@peternewman

Copy link
Copy Markdown
Member Author

@peternewman: Interesting, even though the branch is in your repo, I was able to rebase it on top of latest master using GitHub's web interface.

That may be because of this:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Or possibly simply because you've got OLA write access, but I suspect not unless that box was ticked from the description...

@peternewman peternewman mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants