Add a helper method to convert an RDMResponse to a NACKing RDMResponse - #1828
Conversation
|
Ping @kripton in case you missed it... |
kripton
left a comment
There was a problem hiding this comment.
Looks all good, new test case PASSes on my machine and FAILs if I modify it (just to make sure it was actually run)
(cherry picked from commit 324b4ec)
85da9e8 to
ca5d405
Compare
|
@peternewman: Interesting, even though the branch is in your repo, I was able to rebase it on top of latest master using GitHub's web interface. I'll merge it as soon as all CI checks are green. |
That may be because of this: Or possibly simply because you've got OLA write access, but I suspect not unless that box was ticked from the description... |
(cherry picked from commit 324b4ec)