Skip to content

Update JUnit in pom.xml. Fixes https://github.com/OpenLightingProject/ola/security/dependabot/1 - #1831

Merged
kripton merged 1 commit into
OpenLightingProject:masterfrom
kripton:updateJUnit
Mar 11, 2023
Merged

Update JUnit in pom.xml. Fixes https://github.com/OpenLightingProject/ola/security/dependabot/1#1831
kripton merged 1 commit into
OpenLightingProject:masterfrom
kripton:updateJUnit

Conversation

@kripton

@kripton kripton commented Mar 5, 2023

Copy link
Copy Markdown
Member

Since I'm able to build & test in master branch (in contrast to 0.10, see #1829), I did the bump here. Should probably be back-ported to 0.10 as well but without the changes done in master to the Java build system, I cannot test.
Lots of other dependencies in pom.xml could have been updated as well but since I don't know the implications, I'd rather leave them alone for now.
With updated JUnit, the two "offline" test case pass. I also enabled the "online" test cases (which need a running olad) and they passed as well. A surefire-report is also still generated fine so I don't expect any breakages. Also, since it's no "major-version-bump", a breaking change in jUnit would be surprising.

@kripton kripton added API-Java Language-Java dependencies Pull requests that update a dependency file labels Mar 5, 2023
@kripton
kripton requested a review from peternewman March 5, 2023 21:04
@kripton
kripton force-pushed the updateJUnit branch 2 times, most recently from 119f2b1 to 7b34223 Compare March 5, 2023 22:11

@peternewman peternewman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should be bumping our POM version at all now we require a later dependency (although only a test one). I've no idea how that is supposed to interact...

@kripton
kripton merged commit 2e8bab1 into OpenLightingProject:master Mar 11, 2023
@peternewman

Copy link
Copy Markdown
Member

I also missed that you'd enabled auto-merge, which was blocking on the review rather than the CI...

Since I'm able to build & test in master branch (in contrast to 0.10, see #1829), I did the bump here. Should probably be back-ported to 0.10 as well but without the changes done in master to the Java build system, I cannot test.

I'll reply to that in #1829.

Lots of other dependencies in pom.xml could have been updated as well but since I don't know the implications, I'd rather leave them alone for now.

Yeah I think that's the continual issue with stuff like this unfortunately.

With updated JUnit, the two "offline" test case pass. I also enabled the "online" test cases (which need a running olad) and they passed as well. A surefire-report is also still generated fine so I don't expect any breakages. Also, since it's no "major-version-bump", a breaking change in jUnit would be surprising.

Thanks for the thorough testing too!

@peternewman peternewman added this to the 0.11.0 milestone Mar 11, 2023
@kripton
kripton deleted the updateJUnit branch March 11, 2023 21:04
@peternewman peternewman mentioned this pull request Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API-Java dependencies Pull requests that update a dependency file Language-Java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants