Update JUnit in pom.xml. Fixes https://github.com/OpenLightingProject/ola/security/dependabot/1 - #1831
Conversation
119f2b1 to
7b34223
Compare
peternewman
left a comment
There was a problem hiding this comment.
I wonder if we should be bumping our POM version at all now we require a later dependency (although only a test one). I've no idea how that is supposed to interact...
|
I also missed that you'd enabled auto-merge, which was blocking on the review rather than the CI...
I'll reply to that in #1829.
Yeah I think that's the continual issue with stuff like this unfortunately.
Thanks for the thorough testing too! |
Since I'm able to build & test in master branch (in contrast to 0.10, see #1829), I did the bump here. Should probably be back-ported to 0.10 as well but without the changes done in master to the Java build system, I cannot test.
Lots of other dependencies in pom.xml could have been updated as well but since I don't know the implications, I'd rather leave them alone for now.
With updated JUnit, the two "offline" test case pass. I also enabled the "online" test cases (which need a running olad) and they passed as well. A surefire-report is also still generated fine so I don't expect any breakages. Also, since it's no "major-version-bump", a breaking change in jUnit would be surprising.