Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rating overflow bug (with cheating) #5009

Closed
2 tasks
telk5093 opened this issue Jan 7, 2017 · 2 comments
Closed
2 tasks

Rating overflow bug (with cheating) #5009

telk5093 opened this issue Jan 7, 2017 · 2 comments
Assignees
@IntelOrca
Labels
bug Something went wrong.

Comments

@telk5093
Copy link
Contributor

telk5093 commented Jan 7, 2017 •
edited
Loading

OS: Windows 10
Version: 0.0.6
Commit/Build: 73d1c6a

I doubt that this rating bug should be fixed even though this is occured by using many cheats, but I report it anyway.
Ratings overflow in a certain condition as you can see in the screenshot below.

  • Reproducible in RCT2 (vanilla)?
  • Multiplayer?

Steps to reproduce:

  1. Make a very long distance rollercoaster with power launched mode, maximum speed(922km/h). (chain all tracks if you can)
  2. Check "Allow arbitrary ride type change" cheat.
  3. Change the rollercoaster's type into Launched Freefall
  4. Excitement rate returns over hundred, and others return negative rating with wrong rating strings

Dump file

Screenshots / Video:
image

Save game:
12.zip
@Gymnasiast
Copy link
Member

Since it doesn't cause a crash and since it can only happen with very strange combinations, I agree with you it's not worth to fix it. (And it's sort-of fun to see it glitch like this :P)

@Gymnasiast Gymnasiast added the wontfix Wont be fixed because there is no consensus or it is not a bug. label Jan 9, 2017
@IntelOrca
Copy link
Contributor

I am re-opening this because I think we still need to cap the ratings between the range we expect. As you can see the strings after the ratings are wrong due to them being negative. Things like this can cause crashes or unexpected behaviour.

@IntelOrca IntelOrca reopened this Jan 9, 2017
@IntelOrca IntelOrca added bug Something went wrong. and removed wontfix Wont be fixed because there is no consensus or it is not a bug. labels Jan 9, 2017
@IntelOrca IntelOrca self-assigned this Jan 9, 2017
@janisozaur janisozaur mentioned this issue Jan 10, 2017
Merged
@Voytella Voytella mentioned this issue Apr 7, 2017
Closed
janisozaur added a commit that referenced this issue Jul 12, 2017
@janisozaur
Release v0.1.0
6d1f732 
- Feature: [#1399 (partial), #5177] Add window that displays any missing/corrupt objects when loading a park
- Feature: [#5056] Add cheat to own all land.
- Feature: [#5133] Add option to display guest expenditure (as seen in RCTC).
- Feature: [#5196] Add cheat to disable ride ageing.
- Feature: [#5504] Group vehicles into ride groups
- Feature: [#5576] Add a persistent 'display real names of guests' setting.
- Feature: [#5611] Add support for Android
- Feature: [#5706] Add support for OpenBSD
- Feature: OpenRCT2 now starts up on the display it was last shown on.
- Feature: Park entrance fee can now be set to amounts up to £200.
- Improved: Construction rights can now be placed on park entrances.
- Improved: Mouse can now be dragged to select scenery when saving track designs
- Fix: [#259] Money making glitch involving swamps (original bug)
- Fix: [#441] Construction rights over entrance path erased (original bug)
- Fix: [#578] Ride ghosts show up in ride list during construction (original bug)
- Fix: [#597] 'Finish 5 roller coasters' goal not properly checked (original bug)
- Fix: [#667] Incorrect banner limit calculation (original bug)
- Fix: [#739] Crocodile Ride (Log Flume) never allows more than five boats (original bug)
- Fix: [#837] Can't move windows on title screen to where the toolbar would be (original bug)
- Fix: [#1705] Time Twister's Medieval entrance has incorrect scrolling (original bug)
- Fix: [#3178, #5456] Paths with non-ASCII characters not handled properly on macOS.
- Fix: [#3346] Crash when extra long train breaks down at the back
- Fix: [#3479] Building in pause mode creates too many floating numbers, crashing the game
- Fix: [#3565] Multiplayer server crash
- Fix: [#3681] Steel Twister rollercoaster always shows all track designs
- Fix: [#3846, #5749] Crash when testing coaster with a diagonal lift in block brake mode
- Fix: [#4054] Sorting rides by track type: Misleading research messages
- Fix: [#4055] Sort rides by track type: Sorting rule is not really clear (inconsistent?)
- Fix: [#4512] Invisible map edge tiles corrupted
- Fix: [#5009] Ride rating calculations can overflow
- Fix: [#5253] RCT1 park value conversion factor too high
- Fix: [#5400] New Ride window does not focus properly on newly invented ride.
- Fix: [#5489] Sprite index crash for car view on car ride.
- Fix: [#5730] Unable to uncheck 'No money' in the Scenario Editor.
- Fix: [#5750] Game freezes when ride queue linked list is corrupted.
- Fix: [#5819] Vertical multi-dimension coaster tunnels drawn incorrectly
- Fix: Non-invented vehicles can be used via track designs in select-by-track-type mode.
- Fix: Track components added by OpenRCT2 are now usable in older scenarios.
- Technical: [#5047] Add ride ratings tests
- Technical: [#5458] Begin offering headless build with reduced compile- and run-time dependencies
- Technical: [#5755] Title sequence wait periods use milliseconds
- Technical: Fix many desync sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IntelOrca IntelOrca

Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Gymnasiast @IntelOrca @telk5093