Remove SDL2 dependencies: Phase 1 #5458

IntelOrca · 2017-05-09T18:02:42Z

No description provided.

AaronVanGeffen · 2017-05-09T20:14:18Z

Just to clarify: is the goal to get rid of SDL altogether, or just separate it from the logic to allow for GUI-less builds? I initially thought the latter, but the openrct2-ui tree and its platform-specific window contexts make me think the former is the case.

IntelOrca · 2017-05-09T20:30:13Z

@AaronVanGeffen SDL2 will still be used, we are just trying to extract the logic so that we can build a stand alone CLI version for servers.

The UI context stuff has been designed with SDL2 to be somewhat interchangeable - just so that porting can be done to a platform that SDL2 does not support.

marijnvdwerf · 2017-05-14T19:41:39Z

src/openrct2-cli/Cli.cpp

@@ -0,0 +1,30 @@
+#pragma region Copyright (c) 2014-2016 OpenRCT2 Developers


marijnvdwerf · 2017-05-14T19:42:27Z

src/openrct2-ui/CMakeLists.txt

+    "${CMAKE_CURRENT_LIST_DIR}/*.hpp")
+
+# Outputs
+set (PROJECT openrct2)


why the space?

marijnvdwerf · 2017-05-14T19:43:21Z

src/openrct2-ui/CursorData.cpp


-namespace Cursors
+namespace OpenRCT2 { namespace Ui


Is this supposed to be on a single line?

Yes, I intend on changing it to OpenRCT2::Ui when we can use C++17.

marijnvdwerf · 2017-05-14T19:45:27Z

src/openrct2-ui/UiContext.macOS.mm

+
+        std::string ShowFileDialog(SDL_Window * window, const FileDialogDesc &desc) override
+        {
+			@autoreleasepool


File uses tabs for indenting

marijnvdwerf · 2017-05-14T19:46:41Z

src/openrct2/CMakeLists.txt

+# -Wstrict-overflow is only active when -fstrict-overflow is enabled, but -fstrict-overflow
+# is enabled on -O2, -O3, -Os. This should help catch bugs locally before they reach Travis
+# As of 2a435bf -Wstrict-overflow=1 passes, but higher values do not.
+set(COMMON_COMPILE_OPTIONS "${COMMON_COMPILE_OPTIONS} -fstrict-overflow")


Shouldn't COMMON_COMPILE OPTIONS be added to the c/cxx flags?

Maybe, this was copied from the current one, so if you can improve it - by all means.

marijnvdwerf · 2017-05-14T19:52:12Z

Trying to get Cmake to work on macOS:

[ 93%] Linking CXX shared library libopenrct2.dylib
Undefined symbols for architecture x86_64:
  "_EVP_DigestSignFinal", referenced from:
      NetworkKey::Sign(unsigned char const*, unsigned long, char**, unsigned long*) in NetworkKey.cpp.o
  "_EVP_DigestSignInit", referenced from:
      NetworkKey::Sign(unsigned char const*, unsigned long, char**, unsigned long*) in NetworkKey.cpp.o
  "_EVP_DigestVerifyFinal", referenced from:
      NetworkKey::Verify(unsigned char const*, unsigned long, char const*, unsigned long) in NetworkKey.cpp.o
  "_EVP_DigestVerifyInit", referenced from:
      NetworkKey::Verify(unsigned char const*, unsigned long, char const*, unsigned long) in NetworkKey.cpp.o
  "_EVP_PKEY_CTX_ctrl", referenced from:
      NetworkKey::Generate() in NetworkKey.cpp.o
  "_EVP_PKEY_CTX_free", referenced from:
      NetworkKey::~NetworkKey() in NetworkKey.cpp.o
  "_EVP_PKEY_CTX_new_id", referenced from:
      NetworkKey::NetworkKey() in NetworkKey.cpp.o
  "_EVP_PKEY_keygen", referenced from:
      NetworkKey::Generate() in NetworkKey.cpp.o
  "_EVP_PKEY_keygen_init", referenced from:
      NetworkKey::Generate() in NetworkKey.cpp.o
  "_iconv", referenced from:
      _win1252_to_utf8 in localisation.c.o
  "_iconv_close", referenced from:
      _win1252_to_utf8 in localisation.c.o
  "_iconv_open", referenced from:
      _win1252_to_utf8 in localisation.c.o
ld: symbol(s) not found for architecture x86_64

marijnvdwerf · 2017-05-14T19:54:46Z

Also:

CMake Warning (dev):
  Policy CMP0042 is not set: MACOSX_RPATH is enabled by default.  Run "cmake
  --help-policy CMP0042" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  MACOSX_RPATH is not specified for the following targets:

   libopenrct2

This warning is for project developers.  Use -Wno-dev to suppress it.

IntelOrca · 2017-05-17T15:54:36Z

src/openrct2-ui/TextComposition.cpp

-        // _lastKeyPressed = e.key.keysym.sym;
-        // _keysPressed[e.key.keysym.scancode] = 1;
+
+		GetContext()->GetUiContext()->SetKeysPressed(key, e->key.keysym.scancode);


Already fixed in 961a4dd.

IntelOrca · 2017-05-17T15:54:53Z

src/openrct2-ui/UiContext.cpp

+	{
+			_lastKeyPressed = keysym;
+			_keysPressed[scancode] = 1;
+	}


IntelOrca · 2017-05-17T15:54:59Z

src/openrct2/ui/UiContext.h

@@ -119,6 +119,7 @@ namespace OpenRCT2
            virtual void                SetCursorTrap(bool value) abstract;
            virtual const uint8 *       GetKeysState() abstract;
            virtual const uint8 *       GetKeysPressed() abstract;
+			virtual void				SetKeysPressed(uint32 keysym, uint8 scancode) abstract;


duncanspumpkin · 2017-05-18T08:38:23Z

@rwjuk there is a plugin for visual studio that warns you if you try to save a file with mixed tabs and spaces. It's very useful for this project.

Gymnasiast · 2017-05-18T08:54:09Z

@duncanspumpkin Richard uses macOS and Linux, so a VS plug-in is not an option.

pizza2004 · 2017-05-18T14:16:35Z

Actually, Visual Studio just came out on macOS, but I wouldn't personally use it anyway.

IntelOrca · 2017-05-18T14:20:36Z

@pizza2004 Visual Studio for Mac is very much a different application entirely so you can't use any extensions for VS in VS for Mac.

marijnvdwerf · 2017-05-18T15:06:51Z

What about a git commit hook script?

pizza2004 · 2017-05-18T15:17:21Z

@IntelOrca Obviously, I just thought it was an interesting thing people might like to know.

Gymnasiast · 2017-05-22T18:13:12Z

If I attempt to load a save using the native dialog, no saves are listed. There is also no option to select 'All files' (there used to be). Furthermore, if I click 'Cancel', it will display an error message and force me to select a file, giving me no option to cancel other than forcibly killing the OpenRCT2 process.

Edit: this is all on Ubuntu 17.04.

marijnvdwerf · 2017-05-22T18:17:52Z

Fails at the linking step for me

[361/361] Linking CXX executable openrct2
FAILED: openrct2 
: && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -std=gnu++14  -Wno-error=deprecated-declarations -Wno-error=objc-method-access -fstrict-aliasing -Werror -Wundef -Wmissing-declarations -Winit-self -Wall -Wno-unknown-pragmas -Wno-unused-function -Wno-missing-braces  -Wno-comment -Wshadow  -Wmissing-declarations -Wnonnull -DDEBUG=0 -fPIC  -Wno-error=date-time -Wnull-dereference -Wredundant-decls -Wignored-qualifiers -Wstrict-overflow=1 -std=gnu++14 -Wl,-search_paths_first -Wl,-headerpad_max_install_names  CMakeFiles/openrct2.dir/src/openrct2-ui/CursorData.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/CursorRepository.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/TextComposition.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/Ui.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/UiContext.Linux.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/UiContext.Win32.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/UiContext.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/audio/AudioChannel.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/audio/AudioContext.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/audio/AudioMixer.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/audio/FileAudioSource.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/audio/MemoryAudioSource.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/SoftwareDrawingEngine.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/CopyFramebufferShader.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/DrawImageShader.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/DrawLineShader.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/FillRectShader.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/OpenGLAPI.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/OpenGLDrawingEngine.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/OpenGLFramebuffer.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/OpenGLShaderProgram.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/SwapFramebuffer.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/drawing/engines/opengl/TextureCache.cpp.o CMakeFiles/openrct2.dir/src/openrct2-ui/UiContext.macOS.mm.o  -o openrct2  libopenrct2.dylib -lSDL2 -lSDL2_ttf -lSDL2 -framework OpenGL -ljansson -lspeexdsp -lpng16 -lz -lzip -lz -lzip -ldl -lcurl /usr/local/Cellar/openssl/1.0.2k/lib/libssl.dylib /usr/local/Cellar/openssl/1.0.2k/lib/libcrypto.dylib -lSDL2 -lSDL2_ttf -lSDL2 -lSDL2_ttf /usr/lib/libiconv.dylib && :
Undefined symbols for architecture x86_64:
  "_OBJC_CLASS_$_NSAlert", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSMutableArray", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSOpenPanel", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSSavePanel", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSString", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSURL", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "_OBJC_CLASS_$_NSWindow", referenced from:
      objc-class-ref in UiContext.macOS.mm.o
  "___CFConstantStringClassReference", referenced from:
      CFString in UiContext.macOS.mm.o
      CFString in UiContext.macOS.mm.o
      CFString in UiContext.macOS.mm.o
      CFString in UiContext.macOS.mm.o
      CFString in UiContext.macOS.mm.o
  "_objc_autoreleasePoolPop", referenced from:
      OpenRCT2::Ui::macOSContext::macOSContext() in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowMessageBox(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowFileDialog(SDL_Window*, OpenRCT2::Ui::FileDialogDesc const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowDirectoryDialog(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
  "_objc_autoreleasePoolPush", referenced from:
      OpenRCT2::Ui::macOSContext::macOSContext() in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowMessageBox(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowFileDialog(SDL_Window*, OpenRCT2::Ui::FileDialogDesc const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowDirectoryDialog(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
  "_objc_msgSend", referenced from:
      OpenRCT2::Ui::macOSContext::macOSContext() in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowMessageBox(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowFileDialog(SDL_Window*, OpenRCT2::Ui::FileDialogDesc const&) in UiContext.macOS.mm.o
      OpenRCT2::Ui::macOSContext::ShowDirectoryDialog(SDL_Window*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in UiContext.macOS.mm.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

rwjuk · 2017-05-22T23:18:29Z

@Gymnasiast What OS was this on?

rwjuk · 2017-05-23T00:10:15Z

Tested and working on macOS 10.12

Native file load/save dialogs
TTF display (tested Japanese)
Pointing game to RCT2 & RCT1 path on initial setup (The bug that Guard against null pointer in macos_str_decomp_to_precomp() #5500 fixed is still there, but a rebase should cure that. Setting RCT1 path works apart from that.)

This was causing undefined data to appear in _keysPressed which caused shortcuts to be invoked on startup.

[ci skip]

janisozaur

I haven't tested it thoroughly, but the features I want for now seem to be working. To not hold it off any longer I'm happy to have it merged as-is, with fixes, if any, merged in develop.

janisozaur · 2017-05-30T19:32:51Z

@grahamedgecombe if you're around, can you please also take a look at this? We want to have libopenrct2.so and its clients: openrct2 (GUI) and openrct2-cli (headless build), how would we best address the lookup of libopenrct2.so for portable builds? It may also affect packaging, which I haven't inspected.

grahamedgecombe · 2017-05-30T20:55:54Z

@janisozaur for portable builds set an rpath with $ORIGIN maybe?

Gymnasiast · 2017-05-30T21:43:01Z

With this last commit it appears to work correctly on my system. Moving both the binary and lib from the build dir to the executable dir now works as intended.

grahamedgecombe · 2017-05-31T06:55:59Z

CMakeLists.txt

+    if (PORTABLE)
+        install(TARGETS "libopenrct2" LIBRARY DESTINATION "bin")
+    else ()
+        install(TARGETS "libopenrct2" LIBRARY DESTINATION "usr/local/lib")


The DESTINATION here should just be "lib". cmake already adds the prefix, which may not be /usr/local - e.g. it's /usr in the Arch package.

Currently this results in libopenrct2.so being installed in /usr/usr/local/lib.

So you think it should be lib rather than local/lib?

Yeah, I think it should be install(TARGETS "libopenrct2" LIBRARY DESTINATION "lib").

cmake adds the /usr or /usr/local (or whatever) prefix for you - based on the value of CMAKE_INSTALL_PREFIX.

Thanks, I have changed it back to lib.

Which set rpath to $ORIGIN so it can be run out the box.

marijnvdwerf · 2017-05-31T18:10:22Z

src/openrct2-ui/CMakeLists.txt

@@ -75,6 +75,11 @@ if (WIN32)
    # tell it that it is
    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -D__USE_MINGW_ANSI_STDIO=1")
 endif ()
+
+if (PORTABLE)
+    set(CMAKE_INSTALL_RPATH "$ORIGIN")


Doesn't this get interpreted as "fill with contents of variable named 'ORIGIN'?

CMAKE uses ${...} for variables and $ENV{...} for environment variables. I think this is saw on various internet pages for how to do it in cmake. It works when I build it myself.

set(CMAKE_INSTALL_RPATH "$ORIGIN") needs to go before add_executable() for it to work I think.

Shouldn't the other frontend also receive the same treatment?

@janisozaur Derp. Yes, set(CMAKE_INSTALL_RPATH "$ORIGIN") added for the CLI build.

- Feature: [#1399 (partial), #5177] Add window that displays any missing/corrupt objects when loading a park - Feature: [#5056] Add cheat to own all land. - Feature: [#5133] Add option to display guest expenditure (as seen in RCTC). - Feature: [#5196] Add cheat to disable ride ageing. - Feature: [#5504] Group vehicles into ride groups - Feature: [#5576] Add a persistent 'display real names of guests' setting. - Feature: [#5611] Add support for Android - Feature: [#5706] Add support for OpenBSD - Feature: OpenRCT2 now starts up on the display it was last shown on. - Feature: Park entrance fee can now be set to amounts up to £200. - Improved: Construction rights can now be placed on park entrances. - Improved: Mouse can now be dragged to select scenery when saving track designs - Fix: [#259] Money making glitch involving swamps (original bug) - Fix: [#441] Construction rights over entrance path erased (original bug) - Fix: [#578] Ride ghosts show up in ride list during construction (original bug) - Fix: [#597] 'Finish 5 roller coasters' goal not properly checked (original bug) - Fix: [#667] Incorrect banner limit calculation (original bug) - Fix: [#739] Crocodile Ride (Log Flume) never allows more than five boats (original bug) - Fix: [#837] Can't move windows on title screen to where the toolbar would be (original bug) - Fix: [#1705] Time Twister's Medieval entrance has incorrect scrolling (original bug) - Fix: [#3178, #5456] Paths with non-ASCII characters not handled properly on macOS. - Fix: [#3346] Crash when extra long train breaks down at the back - Fix: [#3479] Building in pause mode creates too many floating numbers, crashing the game - Fix: [#3565] Multiplayer server crash - Fix: [#3681] Steel Twister rollercoaster always shows all track designs - Fix: [#3846, #5749] Crash when testing coaster with a diagonal lift in block brake mode - Fix: [#4054] Sorting rides by track type: Misleading research messages - Fix: [#4055] Sort rides by track type: Sorting rule is not really clear (inconsistent?) - Fix: [#4512] Invisible map edge tiles corrupted - Fix: [#5009] Ride rating calculations can overflow - Fix: [#5253] RCT1 park value conversion factor too high - Fix: [#5400] New Ride window does not focus properly on newly invented ride. - Fix: [#5489] Sprite index crash for car view on car ride. - Fix: [#5730] Unable to uncheck 'No money' in the Scenario Editor. - Fix: [#5750] Game freezes when ride queue linked list is corrupted. - Fix: [#5819] Vertical multi-dimension coaster tunnels drawn incorrectly - Fix: Non-invented vehicles can be used via track designs in select-by-track-type mode. - Fix: Track components added by OpenRCT2 are now usable in older scenarios. - Technical: [#5047] Add ride ratings tests - Technical: [#5458] Begin offering headless build with reduced compile- and run-time dependencies - Technical: [#5755] Title sequence wait periods use milliseconds - Technical: Fix many desync sources

IntelOrca force-pushed the refactor/nosdl/phase-1b branch from 26e80d3 to 453c564 Compare May 9, 2017 18:07

IntelOrca force-pushed the refactor/nosdl/phase-1b branch 2 times, most recently from ad80f0a to 8368b29 Compare May 11, 2017 16:26

janisozaur mentioned this pull request May 12, 2017

Build error when disabling twitch but enabling network #5469

Closed

marijnvdwerf reviewed May 14, 2017

View reviewed changes

janisozaur added the no-SDL label May 17, 2017

IntelOrca commented May 17, 2017

View reviewed changes

src/openrct2-ui/UiContext.cpp Outdated

{

_lastKeyPressed = keysym;

_keysPressed[scancode] = 1;

}

Copy link

Contributor Author

IntelOrca May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs!

IntelOrca commented May 17, 2017

View reviewed changes

rwjuk force-pushed the refactor/nosdl/phase-1b branch 2 times, most recently from 855d9fe to 0fe6667 Compare May 19, 2017 17:56

IntelOrca force-pushed the refactor/nosdl/phase-1b branch 4 times, most recently from ced727b to ef225a6 Compare May 21, 2017 00:08

Gymnasiast mentioned this pull request May 21, 2017

Cmake fixes for SDL-less #5495

Closed

rwjuk and others added 11 commits May 29, 2017 22:38

Fix cmake for OpenRCT2-UI on macOS

7a59eef

Update vscode debug configuration

1eb5ed0

Initialise UiContext input fields

e313568

This was causing undefined data to appear in _keysPressed which caused shortcuts to be invoked on startup.

Fix zenity dialog logic

a15a226

Fix kdialog implementation

4932537

Open the game window on the last remembered display

3ca1b48

Add all files filter

61228fc

Don't check for fontconfig on macOS

615580d

Fix copyright year and comment

a43ee2b

Allow building headless version as a separate target

de9adf5

Add headless builds to travis configurations

8cb24b2

Gymnasiast force-pushed the refactor/nosdl/phase-1b branch from 9dd49a3 to 8cb24b2 Compare May 29, 2017 20:39

Update changelog.txt

5a93b67

[ci skip]

janisozaur approved these changes May 29, 2017

View reviewed changes

IntelOrca force-pushed the refactor/nosdl/phase-1b branch from bd3a6f2 to cb1a2a0 Compare May 30, 2017 21:36

IntelOrca force-pushed the refactor/nosdl/phase-1b branch from cb1a2a0 to 93cf412 Compare May 30, 2017 22:24

grahamedgecombe reviewed May 31, 2017

View reviewed changes

Create portable builds

1e550e9

Which set rpath to $ORIGIN so it can be run out the box.

IntelOrca force-pushed the refactor/nosdl/phase-1b branch from 93cf412 to 1e550e9 Compare May 31, 2017 07:52

marijnvdwerf reviewed May 31, 2017

View reviewed changes

rwjuk added 2 commits May 31, 2017 19:39

Set CMAKE_INSTALL_RPATH before adding executables.

25e50bf

Set CMAKE_INSTALL_RPATH to $ORIGIN on CLI build

8d3b7f8

rwjuk merged commit ab8e895 into develop May 31, 2017

rwjuk mentioned this pull request May 31, 2017

Fix formatting of audio.cpp #5488

Closed

janisozaur mentioned this pull request Jun 1, 2017

Dedicated Server Build #5434

Closed

IntelOrca deleted the refactor/nosdl/phase-1b branch July 12, 2017 14:00

		@@ -0,0 +1,30 @@
		#pragma region Copyright (c) 2014-2016 OpenRCT2 Developers

Remove SDL2 dependencies: Phase 1 #5458

Remove SDL2 dependencies: Phase 1 #5458

Conversation

IntelOrca commented May 9, 2017

AaronVanGeffen commented May 9, 2017

IntelOrca commented May 9, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marijnvdwerf commented May 14, 2017

marijnvdwerf commented May 14, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

duncanspumpkin commented May 18, 2017

Gymnasiast commented May 18, 2017

pizza2004 commented May 18, 2017

IntelOrca commented May 18, 2017

marijnvdwerf commented May 18, 2017

pizza2004 commented May 18, 2017

Gymnasiast commented May 22, 2017 • edited Loading

marijnvdwerf commented May 22, 2017

rwjuk commented May 22, 2017

rwjuk commented May 23, 2017 • edited Loading

janisozaur left a comment

Choose a reason for hiding this comment

janisozaur commented May 30, 2017

grahamedgecombe commented May 30, 2017

Gymnasiast commented May 30, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grahamedgecombe May 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

IntelOrca May 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Gymnasiast commented May 22, 2017 •

edited

Loading

rwjuk commented May 23, 2017 •

edited

Loading

grahamedgecombe May 31, 2017 •

edited

Loading

IntelOrca May 31, 2017 •

edited

Loading