Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when extra long train breaks down at the back #3346

Closed
2 tasks
jensj12 opened this issue Apr 19, 2016 · 19 comments
Closed
2 tasks

Crash when extra long train breaks down at the back #3346

jensj12 opened this issue Apr 19, 2016 · 19 comments
Labels
crash Game exits suddenly. investigate Not sure what the problem is yet.

Comments

@jensj12
Copy link
Contributor

jensj12 commented Apr 19, 2016 •
edited

OS: Win10
Version: v0.0.5 develop
Commit: 385b03e

Two crashes (edit: three) during my contribution to the group park of the forum, dumps attached.

  • Reproducible in RCT2 (vanilla)?
  • Multiplayer?

Steps to reproduce:
Just play the game (I was playing singleplayer) :P

Dump/save file
OpenRCT2crashes.zip
@IntelOrca
Copy link
Contributor

IntelOrca commented Apr 19, 2016 •
edited

I can't load the saved games because I do not have the required objects. Most multiplayer games crash because they contain an invalid track piece (which fails to draw). We don't know what causes this to happen.

@jensj12
Copy link
Contributor Author

jensj12 commented Apr 19, 2016

Opening this save should give you all the required objects (two path types and two rides): The OpenRCT Group Park 3.18.zip

@IntelOrca
Copy link
Contributor

IntelOrca commented Apr 19, 2016 •
edited 

Unhandled exception thrown: read access violation.

vehicle_type->peep_loading_positions was nullptr.

Ride: 26
Ride Entry: 30
Train: 0

Some kind of issue with it being unsuccessful about getting the vehicle entries.

@janisozaur
Copy link
Member

Has anyone tinkered with that save using the longer trains cheat?

@jensj12
Copy link
Contributor Author

jensj12 commented Apr 19, 2016

Yes, there's a ride with 16 cars per train / 1 train (King of Durango Mountain). Got a crash on the stable build as well. Is there any way to see the ID of a ride in-game?

@IntelOrca
Copy link
Contributor

@jensj12 no, but I wish there was

@jensj12
Copy link
Contributor Author

jensj12 commented Apr 19, 2016

Even with that cheated ride closed the game still crashes. I'll be waiting for a console command to get the ride name by ride ID. Here's the dump from the last crash (hope it helps): OpenRCT2crashes2.zip

@IntelOrca
Copy link
Contributor

@jensj12 From 44717cf there should now be a console command which lists the rides against IDs.

@jensj12
Copy link
Contributor Author

jensj12 commented Apr 20, 2016

Ride 26 is a custom ride named treetop bouncers (subtype 30) and ride 30 is King of Darungo Mountain (can't find 26 anywhere there) with cheated train lenght. I'll try to debug more when I have the time (which won't be until saturday).

@Gymnasiast Gymnasiast added the investigate Not sure what the problem is yet. label Apr 21, 2016
@jensj12
Copy link
Contributor Author

jensj12 commented May 3, 2016 •
edited

I've found the cause, here are the steps to reproduce (not sure if step 2 is needed):

  1. Use the disable train lenght limit cheat and build a coaster with more cars than normally allowed.
  2. Disable the cheat.
  3. Wait for a restraints stuck open/closed breakdown applied to one of the cars that normally can't exist.
  4. Crash... OpenRCT2crashes3.zip
    This dump is created with build 98bff69
    It crashes here: https://github.com/OpenRCT2/OpenRCT2/blob/develop/src/ride/ride.c#L2328

@Gymnasiast Gymnasiast added the crash Game exits suddenly. label May 24, 2016
@Chaosmeister
Copy link
Contributor

I can't open any save file from this issue.

@Krutonium
Copy link
Member

@Chaosmeister Opened fine for me.

@Chaosmeister
Copy link
Contributor

I'm unable to reproduce the crash.

@jensj12
Copy link
Contributor Author

jensj12 commented Jul 9, 2017

image
I still get the crash (or rather, an assertion) when trying to force a breakdown on King of Durango Mountain. Whenever it does not crash, the breakdown is triggered in the front half of the train, so you may need to try a few times.
The OpenRCT Group Park 3.17.txt (earlier version of the same park as before)

@jensj12 jensj12 changed the title Crashes at random times Crash when extra long train breaks down at the back Jul 9, 2017
@jensj12
Copy link
Contributor Author

jensj12 commented Jul 9, 2017

I can't reproduce this with other coasters. @Broxzier: How did you build that coaster?

@Broxzier
Copy link
Member

Broxzier commented Jul 9, 2017

I don't thing I've used any hacks for this ride, other than the longer trains. At the time, that was a relatively new feature, and it may have set something wrong. Is the assertion still hit after double-closing the ride, and changing the train length?

@Chaosmeister
Copy link
Contributor

Chaosmeister commented Jul 10, 2017 •
edited

I can finally reproduce the asserts + crashes.

To fix:

  • shutdown with restraints stuck closed
  • force repair the track after forcing a shutdown
  • maybe more.

@jensj12
Copy link
Contributor Author

jensj12 commented Jul 11, 2017

I closed the coaster, set the number of cars per train to what it was before and reopened the ride. No more crashes, and I noticed a subtle difference in the vehicle tab: before resetting it showed 2 trains of 7 cars (while only 1 train of 16 cars exists), after resetting the vehicle tab showed the correct number of cars.

I have no idea how to get a coaster into that bugged state.

@Chaosmeister
Copy link
Contributor

all shutdown crashes are caused by an invalid state of the ride.
ride->num_vehicles is 2 and ->num_cars_per_train is 7, but there is only 1 vehicle with about 16 cars.

@Chaosmeister Chaosmeister mentioned this issue Jul 11, 2017
Merged
janisozaur added a commit that referenced this issue Jul 12, 2017
@janisozaur
Release v0.1.0
6d1f732 
- Feature: [#1399 (partial), #5177] Add window that displays any missing/corrupt objects when loading a park
- Feature: [#5056] Add cheat to own all land.
- Feature: [#5133] Add option to display guest expenditure (as seen in RCTC).
- Feature: [#5196] Add cheat to disable ride ageing.
- Feature: [#5504] Group vehicles into ride groups
- Feature: [#5576] Add a persistent 'display real names of guests' setting.
- Feature: [#5611] Add support for Android
- Feature: [#5706] Add support for OpenBSD
- Feature: OpenRCT2 now starts up on the display it was last shown on.
- Feature: Park entrance fee can now be set to amounts up to £200.
- Improved: Construction rights can now be placed on park entrances.
- Improved: Mouse can now be dragged to select scenery when saving track designs
- Fix: [#259] Money making glitch involving swamps (original bug)
- Fix: [#441] Construction rights over entrance path erased (original bug)
- Fix: [#578] Ride ghosts show up in ride list during construction (original bug)
- Fix: [#597] 'Finish 5 roller coasters' goal not properly checked (original bug)
- Fix: [#667] Incorrect banner limit calculation (original bug)
- Fix: [#739] Crocodile Ride (Log Flume) never allows more than five boats (original bug)
- Fix: [#837] Can't move windows on title screen to where the toolbar would be (original bug)
- Fix: [#1705] Time Twister's Medieval entrance has incorrect scrolling (original bug)
- Fix: [#3178, #5456] Paths with non-ASCII characters not handled properly on macOS.
- Fix: [#3346] Crash when extra long train breaks down at the back
- Fix: [#3479] Building in pause mode creates too many floating numbers, crashing the game
- Fix: [#3565] Multiplayer server crash
- Fix: [#3681] Steel Twister rollercoaster always shows all track designs
- Fix: [#3846, #5749] Crash when testing coaster with a diagonal lift in block brake mode
- Fix: [#4054] Sorting rides by track type: Misleading research messages
- Fix: [#4055] Sort rides by track type: Sorting rule is not really clear (inconsistent?)
- Fix: [#4512] Invisible map edge tiles corrupted
- Fix: [#5009] Ride rating calculations can overflow
- Fix: [#5253] RCT1 park value conversion factor too high
- Fix: [#5400] New Ride window does not focus properly on newly invented ride.
- Fix: [#5489] Sprite index crash for car view on car ride.
- Fix: [#5730] Unable to uncheck 'No money' in the Scenario Editor.
- Fix: [#5750] Game freezes when ride queue linked list is corrupted.
- Fix: [#5819] Vertical multi-dimension coaster tunnels drawn incorrectly
- Fix: Non-invented vehicles can be used via track designs in select-by-track-type mode.
- Fix: Track components added by OpenRCT2 are now usable in older scenarios.
- Technical: [#5047] Add ride ratings tests
- Technical: [#5458] Begin offering headless build with reduced compile- and run-time dependencies
- Technical: [#5755] Title sequence wait periods use milliseconds
- Technical: Fix many desync sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash Game exits suddenly. investigate Not sure what the problem is yet.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@janisozaur @Gymnasiast @IntelOrca @Krutonium @Broxzier @Chaosmeister @jensj12