Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunnel portal drawing regression #5819

Closed
spacek531 opened this issue Jul 7, 2017 · 1 comment
Closed

tunnel portal drawing regression #5819

spacek531 opened this issue Jul 7, 2017 · 1 comment
Assignees
@duncanspumpkin
Labels
bug Something went wrong.

Comments

@spacek531
Copy link
Contributor

Commit/Build: one of the last 0.0.8 builds

The steep-slope-to-vertical piece is allowed to stick out 2 units above ground in RCT2. OpenRCT2 0.0.5 draws portals for this correctly:
image

0.0.8 (and by extension 0.1.0, in the beginning) does not draw this correctly:
image
@rwjuk rwjuk added the bug Something went wrong. label Jul 7, 2017
@duncanspumpkin duncanspumpkin self-assigned this Jul 9, 2017
duncanspumpkin added a commit to duncanspumpkin/OpenRCT2 that referenced this issue Jul 9, 2017
@duncanspumpkin
Fix tunnel portal drawing for multidim inverted track.
b1a01b0 
Mistake made from generated code. Missed in OpenRCT2#5087. Fixes OpenRCT2#5819.
@duncanspumpkin duncanspumpkin mentioned this issue Jul 9, 2017
Merged
@duncanspumpkin
Copy link
Contributor

Its not really a regression its just been wrong since it was implemented.

Gymnasiast added a commit to duncanspumpkin/OpenRCT2 that referenced this issue Jul 9, 2017
@Gymnasiast
Add OpenRCT2#5819 to changelog
aaef0a9
Gymnasiast pushed a commit that referenced this issue Jul 9, 2017
@duncanspumpkin @Gymnasiast
Fix tunnel portal drawing for multidim inverted track.
540763a 
Mistake made from generated code. Missed in #5087. Fixes #5819.
Gymnasiast added a commit that referenced this issue Jul 9, 2017
@Gymnasiast
Add #5819 to changelog
ba2f129
janisozaur added a commit that referenced this issue Jul 12, 2017
@janisozaur
Release v0.1.0
6d1f732 
- Feature: [#1399 (partial), #5177] Add window that displays any missing/corrupt objects when loading a park
- Feature: [#5056] Add cheat to own all land.
- Feature: [#5133] Add option to display guest expenditure (as seen in RCTC).
- Feature: [#5196] Add cheat to disable ride ageing.
- Feature: [#5504] Group vehicles into ride groups
- Feature: [#5576] Add a persistent 'display real names of guests' setting.
- Feature: [#5611] Add support for Android
- Feature: [#5706] Add support for OpenBSD
- Feature: OpenRCT2 now starts up on the display it was last shown on.
- Feature: Park entrance fee can now be set to amounts up to £200.
- Improved: Construction rights can now be placed on park entrances.
- Improved: Mouse can now be dragged to select scenery when saving track designs
- Fix: [#259] Money making glitch involving swamps (original bug)
- Fix: [#441] Construction rights over entrance path erased (original bug)
- Fix: [#578] Ride ghosts show up in ride list during construction (original bug)
- Fix: [#597] 'Finish 5 roller coasters' goal not properly checked (original bug)
- Fix: [#667] Incorrect banner limit calculation (original bug)
- Fix: [#739] Crocodile Ride (Log Flume) never allows more than five boats (original bug)
- Fix: [#837] Can't move windows on title screen to where the toolbar would be (original bug)
- Fix: [#1705] Time Twister's Medieval entrance has incorrect scrolling (original bug)
- Fix: [#3178, #5456] Paths with non-ASCII characters not handled properly on macOS.
- Fix: [#3346] Crash when extra long train breaks down at the back
- Fix: [#3479] Building in pause mode creates too many floating numbers, crashing the game
- Fix: [#3565] Multiplayer server crash
- Fix: [#3681] Steel Twister rollercoaster always shows all track designs
- Fix: [#3846, #5749] Crash when testing coaster with a diagonal lift in block brake mode
- Fix: [#4054] Sorting rides by track type: Misleading research messages
- Fix: [#4055] Sort rides by track type: Sorting rule is not really clear (inconsistent?)
- Fix: [#4512] Invisible map edge tiles corrupted
- Fix: [#5009] Ride rating calculations can overflow
- Fix: [#5253] RCT1 park value conversion factor too high
- Fix: [#5400] New Ride window does not focus properly on newly invented ride.
- Fix: [#5489] Sprite index crash for car view on car ride.
- Fix: [#5730] Unable to uncheck 'No money' in the Scenario Editor.
- Fix: [#5750] Game freezes when ride queue linked list is corrupted.
- Fix: [#5819] Vertical multi-dimension coaster tunnels drawn incorrectly
- Fix: Non-invented vehicles can be used via track designs in select-by-track-type mode.
- Fix: Track components added by OpenRCT2 are now usable in older scenarios.
- Technical: [#5047] Add ride ratings tests
- Technical: [#5458] Begin offering headless build with reduced compile- and run-time dependencies
- Technical: [#5755] Title sequence wait periods use milliseconds
- Technical: Fix many desync sources
ZehMatt pushed a commit to ZehMatt/OpenRCT2 that referenced this issue Jul 14, 2017
@duncanspumpkin @ZehMatt
Fix tunnel portal drawing for multidim inverted track.
1fa4eaf 
Mistake made from generated code. Missed in OpenRCT2#5087. Fixes OpenRCT2#5819.
ZehMatt pushed a commit to ZehMatt/OpenRCT2 that referenced this issue Jul 14, 2017
@Gymnasiast @ZehMatt
Add OpenRCT2#5819 to changelog
efd048c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duncanspumpkin duncanspumpkin

Labels
bug Something went wrong.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duncanspumpkin @spacek531 @rwjuk