Allow changing the path to refine.ini via refine.sh/bat on command line

[tejasrbhat]

Fixes #4113

[thadguidry]

Tested on Windows. refine-dev.ini still overrides even when /c flag was used, which is expected handling. Great Job @tejasrbhat !

Someone else will need to test on Linux before we can approve and merge.

[tejasrbhat]

@thadguidry I ran bash script in debug mode and the flow is correct. Do you know anyone who can test it ? @wetneb ?

[wetneb]

Nice! But I am not sure why refine-dev.ini should always have priority even when another filename is passed on the command line? Why not just do what the user wants and use the file they specify? @thadguidry you are generally in favour of giving full control to users, no?

[thadguidry]

@wetneb yes but thought since I currently use the dev file in stash and pop as needed it was as convenient enough but yeah probably easier to just command line for that also

[tejasrbhat]

@thadguidry @wetneb I think we can completely remove the logic for refine-dev.ini. If we need to run with dev config we can pass refine-dev.ini path. If its not passed it will take refine.ini in the default path anyway. I don't think we need to maintain default for refine.ini and refine-dev.ini both. What's your thought ? Let me know, I can go ahead and do the changes.

[wetneb]

That would be fine with me too.

[thadguidry]

@tejasrbhat The refine-dev.ini is convenient in that I create one in my local repo path and then I can just use my IDE functionality without typing or pasting a command line. The idea of the -dev file was that it was exactly for that...when your in development and need to repeatedly test things typically using your IDE.

The idea of the -c config file parameter was for NOT DEV and for Users instead who often need to have specific settings depending on the kinds of workflow or project-based work they might be doing that day or week or month.

But using the -dev file with the -c config parameter is OK for me (I will likely save the launch command for my IDE, which all of them support that method for runtime testing a Java application - the typical command launch scenario is usually java -jar xxxx but it can be anything like our refine.bat -c xxxx

So yeah, fine to remove the logic currently for refine-dev.ini default.

[tejasrbhat]

@thadguidry @wetneb done the changes. I debugged the bash script for both custom and default, and flow looks fine. Attaching the screenshots for the same.

[tejasrbhat]

@thadguidry I will look into it

[tejasrbhat]

@wetneb @thadguidry sorry for fixing this so late. Was busy with personal work. I have fixed the issue with double quotes and tested. @thadguidry you can test it once and let me know if anything else needs to be added.

[thadguidry]

@tejasrbhat tested and now works great! Thanks so much for adding this command flag! (and pushing yourself to help get it finished! We thank you!)