feat: 8 missing eval datasets, sources for 12 external skills, 100% skillmgr coverage#361
Merged
Merged
Conversation
…killmgr coverage - 8 new eval datasets: skill-browser, skill-design, skill-ecosystem, skill-infrastructure, skill-memory, skill-planning, skill-process, skill-shop (11 total now, all categories covered) - evals/README.md: 8 new rows in catalog table - 12 external skills: sources: field added to metadata frontmatter - skill-code-graph: 4 .gitkeep files removed (real .md files exist now) - skillmgr test coverage: 99% → 100% (added test for empty/whitespace skill name edge case in MergeRequiredTools) - Validator: 37/37 skills pass --strict, 0 failed
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown)
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown) Run ID:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // ScanFile reads a single file and returns all markers found. | ||
| func (d *AutoDiscover) ScanFile(path string) ([]TodoMarker, error) { | ||
| f, err := os.Open(path) |
| var b []byte | ||
| for _, f := range v { | ||
| bits := math.Float32bits(f) | ||
| b = append(b, byte(bits), byte(bits>>8), byte(bits>>16), byte(bits>>24)) |
| var b []byte | ||
| for _, f := range v { | ||
| bits := math.Float32bits(f) | ||
| b = append(b, byte(bits), byte(bits>>8), byte(bits>>16), byte(bits>>24)) |
| var b []byte | ||
| for _, f := range v { | ||
| bits := math.Float32bits(f) | ||
| b = append(b, byte(bits), byte(bits>>8), byte(bits>>16), byte(bits>>24)) |
| return fmt.Errorf("instinct: demote update: %w", err) | ||
| } | ||
| } else { | ||
| if _, err := tx.ExecContext(ctx, `UPDATE instincts SET confidence = `+newConf+` WHERE id = ?`, id); err != nil { |
| type gitCmdRunner struct{} | ||
|
|
||
| func (gitCmdRunner) worktreeAdd(root, branch, path string) (string, error) { | ||
| cmd := exec.Command("git", "worktree", "add", "-b", branch, path, "HEAD") |
| m.mu.Unlock() | ||
| return errors.New("agentteams: already locked") | ||
| } | ||
| f, err := os.OpenFile(m.path, os.O_CREATE|os.O_RDWR, 0o644) |
| return time.Time{} | ||
| } | ||
| var t time.Time | ||
| json.Unmarshal(v, &t) |
| var obj map[string]json.RawMessage | ||
| if json.Unmarshal(v, &obj) == nil { | ||
| if text, ok := obj["text"]; ok { | ||
| json.Unmarshal(text, &s) |
| m.mu.Lock() | ||
| m.lockFile = nil | ||
| m.mu.Unlock() | ||
| f.Close() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the SOTA skill infrastructure.
Changes
8 new eval datasets (all 11 categories now covered)
12 external skills: sources: field added
lifecycle: externalskills now document their origin in metadata.sourcesskill-code-graph cleanup
skillmgr 100% coverage
Test results