Skip to content

chore: Improve docker builds - #231

Merged
hhvrc merged 3 commits into
developfrom
chore/debian-trixie-slim
Jul 27, 2026
Merged

chore: Improve docker builds#231
hhvrc merged 3 commits into
developfrom
chore/debian-trixie-slim

Conversation

@hhvrc

@hhvrc hhvrc commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@hhvrc hhvrc self-assigned this Jul 27, 2026
Copilot AI review requested due to automatic review settings July 27, 2026 22:46
@ghost

ghost commented Jul 27, 2026

Copy link
Copy Markdown

Ready to review this PR? Stage has broken it down into 1 individual chapter for you:

Title
1 Update Docker build environment and base image
Open in Stage

Chapters generated by Stage for commit a0db155 on Jul 27, 2026 11:27pm UTC.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the project’s container base image to use the Debian “trixie-slim” Node image variant instead of Alpine, aligning the Docker runtime with a glibc-based distro image.

Changes:

  • Switch Docker base image from node:<version>-alpine<alpine_version> to node:<version>-trixie-slim.
  • Remove the now-unused ALPINE_VERSION build argument.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hhvrc
hhvrc requested a review from LucHeart July 27, 2026 22:51
Copilot AI review requested due to automatic review settings July 27, 2026 23:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

Dockerfile:2

  • The header comment says “Define versions as build arguments”, but this Dockerfile now only defines a single build-arg (PNPM_VERSION). Updating the comment avoids misleading future edits.
# Define versions as build arguments for easy updates
ARG PNPM_VERSION=11.17.0

@hhvrc hhvrc changed the title chore: Change docker base image to node trixie slim chore: Improve docker builds Jul 27, 2026
@hhvrc
hhvrc merged commit d3578e6 into develop Jul 27, 2026
11 checks passed
@hhvrc
hhvrc deleted the chore/debian-trixie-slim branch July 27, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants