Skip to content

chore: Improve docker builds #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hhvrc merged 3 commits into from
Jul 27, 2026
Merged

chore: Improve docker builds #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8d580cb
Change docker base image to node trixie slim
hhvrc Jul 27, 2026
8adbbef
pin image and do file copies in one layer
hhvrc Jul 27, 2026
a0db155
Improve docker file
hhvrc Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.DS_Store
.git
.gitignore
node_modules
/build
/.svelte-kit
Expand Down
40 changes: 20 additions & 20 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,39 @@
# Define versions as build arguments for easy updates
ARG NODE_VERSION=26.3.1
ARG PNPM_VERSION=11.8.0
ARG ALPINE_VERSION=3.23
ARG PNPM_VERSION=11.17.0

FROM node:${NODE_VERSION}-alpine${ALPINE_VERSION}
FROM node:26.3.1-trixie-slim@sha256:f9b8bd6c62fcd007c08ce2bb2907485b624b968fd76094445822e0ec14002cf0

ARG PNPM_VERSION
ARG GIT_BRANCH
ARG GIT_COMMIT_SHA

RUN npm install -g pnpm@${PNPM_VERSION}

WORKDIR /app
ENV DOCKER=true
ENV NODE_ENV=production
ENV GIT_BRANCH=${GIT_BRANCH}
ENV GIT_COMMIT_SHA=${GIT_COMMIT_SHA}

# Copy dependency manifests first (for caching)
COPY package.json .
COPY pnpm-lock.yaml .
COPY pnpm-workspace.yaml .
# Copy only files that affect dependency fetching.
COPY pnpm-lock.yaml pnpm-workspace.yaml ./
COPY patches/ patches/

# Install pnpm via npm (works on any platform/libc, no tarball extraction needed)
RUN npm install -g pnpm@${PNPM_VERSION}

# Install all deps (incl. dev) — needed because the build runs at container start.
# --prod=false forces dev deps even though NODE_ENV=production is set above.
RUN pnpm install --frozen-lockfile --strict-peer-dependencies --prod=false
# Populate pnpm's package store with production and development dependencies.
RUN pnpm fetch

# Copy full source after dependencies are cached
# Copy source code and all workspace package.json files.
COPY . .

# Construct node_modules from the populated store.
RUN pnpm install --offline --frozen-lockfile --strict-peer-dependencies --prod=false

# Make entrypoint executable (in case the host bit was lost)
RUN chmod +x /app/docker-entrypoint.sh

# Frequently changing build metadata goes after dependency installation.
ARG GIT_BRANCH
ARG GIT_COMMIT_SHA

ENV NODE_ENV=production
ENV GIT_BRANCH=${GIT_BRANCH}
ENV GIT_COMMIT_SHA=${GIT_COMMIT_SHA}

EXPOSE 3000

ENTRYPOINT ["/app/docker-entrypoint.sh"]
Loading