Skip to content

Better forum layout according to browser size#443

Merged
Martii merged 1 commit intoOpenUserJS:masterfrom
jerone:issue-435-layout
Nov 23, 2014
Merged

Better forum layout according to browser size#443
Martii merged 1 commit intoOpenUserJS:masterfrom
jerone:issue-435-layout

Conversation

@jerone
Copy link
Copy Markdown
Contributor

@jerone jerone commented Nov 23, 2014

Ref: #435

I agree with @TimidScript that the forum could utilize it's space better on big screens.

What I did was make the menu slide to the left of the forum posts on desktop (and bigger) browsers.

Better forum layout according to browser size

@Martii
Copy link
Copy Markdown
Member

Martii commented Nov 23, 2014

+1 so far

Just some ramblings:

  • At width 993px and 994px here is when this (forum names/discussion group names) reverts to being top oriented instead of a left sidebar.
  • Glad you kept what the forum names are... some visitors need explicit definition on what the forums do... USO was always getting something in the wrong place and they didn't have metaphoric forums names.

@Martii
Copy link
Copy Markdown
Member

Martii commented Nov 23, 2014

btw you PR READY or still working on something?

@jerone jerone added the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 23, 2014
@jerone
Copy link
Copy Markdown
Contributor Author

jerone commented Nov 23, 2014

At width 993px and 994px here is when this reverts to being top oriented instead of a left sidebar.

Correct.

@Martii
Copy link
Copy Markdown
Member

Martii commented Nov 23, 2014

A reason why PR READY was adopted is to help us vote more accurately when it's actually ready... technically we shouldn't be voting without this... and thanks.

@Martii
Copy link
Copy Markdown
Member

Martii commented Nov 23, 2014

I have to get a deploy request put in so merging this.

Martii added a commit that referenced this pull request Nov 23, 2014
Better forum layout according to browser size

merge
@Martii Martii merged commit 6e977e4 into OpenUserJS:master Nov 23, 2014
@jerone jerone deleted the issue-435-layout branch November 23, 2014 22:11
@Martii Martii removed the PR READY This is used to indicate that a pull request (PR) is ready for evaluation. label Nov 23, 2014
@jerone jerone mentioned this pull request Nov 23, 2014
@Martii Martii added the UI Pertains inclusively to the User Interface. label Nov 24, 2014
@jerone jerone mentioned this pull request Dec 3, 2014
Martii pushed a commit to Martii/OpenUserJS.org that referenced this pull request Jan 14, 2015
* Panel was initialized with pagination that skewed off center for additions and compounded by OpenUserJS#443. This should align the existing pagination properly.

Applies to OpenUserJS#531
@Martii Martii added the enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. label Jan 14, 2015
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Development

Successfully merging this pull request may close these issues.

2 participants