CI: dont set path twice & bundle: avoid --without & Drop redundant MRI matrix from rspec-tests#533
Merged
Merged
Conversation
bastelfreak
enabled auto-merge
July 24, 2026 12:04
we do `bundle config set path`, so we don't need to provide `--path`. Signed-off-by: Tim Meusel <tim@bastelfreak.de> (cherry picked from commit 26e490f)
`--without` is deprecated and superseeded by `bundle config set...` Signed-off-by: Tim Meusel <tim@bastelfreak.de> (cherry picked from commit 68e27de)
bastelfreak
force-pushed
the
backport-530-to-8.x
branch
from
July 24, 2026 12:08
3beb074 to
acc1e6f
Compare
Contributor
|
The rpm/deb packages and the JAR file for openvox-server are available in a zip archive: |
bastelfreak
commented
Jul 24, 2026
rake spec launches the puppet/puppetserver ruby specs in a single short-lived JRuby via lein run -m org.jruby.Main, which defaults to compile-mode JIT. --dev turns the JIT off, favoring startup time over peak optimization -- the right trade for a one-shot spec runner, and consistent with the server's own JRuby pools, which already default to compile-mode :off via jruby-utils. Verified against JRuby 10.0.5.0 that org.jruby.Main accepts --dev in-process (compile mode JIT -> OFF). The same flag is applied to the spec:init bundle install, which runs under the same JRuby. Trade-off note: JIT-optimizer-specific behavior is less exercised, but these specs test openvox-server's ruby code, not JRuby's optimizer -- and production pools run with the JIT off anyway. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com> (cherry picked from commit b6d3535)
The rspec-tests job matrixed over MRI 3.1-4.0, but the specs never run under that Ruby: rake spec executes them inside the JRuby pinned by jruby-utils (lein run -m org.jruby.Main), and matrix.ruby only selects the MRI that runs rake and dev-setup. All five variants per Java version were testing the same thing. Keep one MRI (3.3, matching the build job and Dockerfile reference Ruby), reducing 10 jobs per PR to 2. If exercising the specs under multiple Ruby *language* versions is ever wanted, that is controlled by the JRuby version in jruby-utils, not by this matrix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: Steven Pritchard <steven.pritchard@gmail.com> (cherry picked from commit 6969e33)
bastelfreak
changed the title
Contributor
Author
|
Those are all backports from |
rwaffen
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues