fix(bench): regenerate anvil state dump and pin anvil version in CI#348
Merged
Conversation
The committed state_100000.json.gz dump was unloadable by every current anvil release (v1.5.1 errors on missing `index` in receipts, v1.7.0 and nightly error on SerializableTransactionType), breaking the PR and base benchmark workflows. Regenerate the dump with anvil v1.7.0 and pin the foundry-toolchain action to v1.7.0 in both workflows so the loader and the dump stay in lockstep — bumping anvil now requires regenerating the dump. Also add `alloy/provider-ws` to the `bench-utils` feature so `cargo run --bin generate_dump --features bench-utils` can connect over websockets (dev-dependencies don't apply to `cargo run --bin`).
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores benchmark CI reliability by regenerating the committed Anvil state dump using a compatible Anvil release and ensuring CI installs a matching Foundry/Anvil toolchain version. It also updates the bench-utils feature set so the dump generator binary can connect to Anvil over WebSockets when run via cargo run.
Changes:
- Regenerate and update metadata for the
state_100000benchmark dump using a newer Anvil version. - Pin the Foundry/Anvil toolchain version used in benchmark workflows to
v1.7.0to match the dump format. - Add
alloy/provider-wsto thebench-utilsfeature to supportcargo run --bin generate_dump --features bench-utils.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
Cargo.toml |
Extends bench-utils to enable Alloy WebSocket provider support for the dump generator. |
benches/dumps/state_100000.metadata.json |
Updates dump metadata (block number, generation time, and Anvil version) to reflect the regenerated dump. |
.github/workflows/pr_benchmarks.yml |
Pins installed Foundry/Anvil toolchain version used by PR benchmark CI runs. |
.github/workflows/base_benchmarks.yml |
Pins installed Foundry/Anvil toolchain version used by base benchmark CI runs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | fix-bench-dump |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | milliseconds (ms) |
|---|---|---|
| historic_scanning/blocks/14131 | 📈 view plot 🚷 view threshold | 230.65 ms |
| historic_scanning/blocks/2826 | 📈 view plot 🚷 view threshold | 75.96 ms |
| historic_scanning/blocks/28263 | 📈 view plot 🚷 view threshold | 429.76 ms |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
pepebndc
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See [failing CIs]:
The committed state_100000.json.gz dump was unloadable by every current anvil release (v1.5.1 errors on missing
indexin receipts, v1.7.0 and nightly error on SerializableTransactionType), breaking the PR and base benchmark workflows. Regenerate the dump with anvil v1.7.0 and pin the foundry-toolchain action to v1.7.0 in both workflows so the loader and the dump stay in lockstep — bumping anvil now requires regenerating the dump.Also add
alloy/provider-wsto thebench-utilsfeature socargo run --bin generate_dump --features bench-utilscan connect over websockets (dev-dependencies don't apply tocargo run --bin).