[N-01] Timelock audit

[ericnordelo]

Summary by CodeRabbit

• Bug Fixes
  • Updated several error messages shown when timed operations fail, making them clearer and more consistent.
  • Improved wording for role mismatch, minimum delay, and parameter/action mismatch errors without changing any behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec671158-21da-4b4e-a451-d9eb8675b520

📥 Commits

Reviewing files that changed from the base of the PR and between bb2405c and f19e2c0.

📒 Files selected for processing (1)

• contracts/timelock/sources/timelock.move

---

📝 Walkthrough

Walkthrough

Reworded several #[error] abort reason strings in the timelock Move contract, including EWrongRole, EDelayTooShort, EScheduleOverflow, EWrongParams, and EWrongAction. Error codes and control flow remain unchanged.

Changes

Timelock error message updates

Layer / File(s)	Summary
Reworded error constant messages contracts/timelock/sources/timelock.move	Updated abort reason text for EWrongRole, EDelayTooShort, EScheduleOverflow, EWrongParams, and EWrongAction constants; error codes and logic unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

• OpenZeppelin/contracts-sui#409: Both PRs touch the timelock error handling in contracts/timelock/sources/timelock.move, with the original PR introducing the error constants this PR revises.

Suggested reviewers: 0xNeshi, bidzyyys, immrsd

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is missing entirely and does not follow the required template sections.	Add the required template content: issue number, a summary of the changes, and the PR checklist entries for Tests, Documentation, and Changelog.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is related to the timelock audit changes, though it is broader than the specific error-message updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/-timelock-audit-N-01

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.38%. Comparing base (bb2405c) to head (f19e2c0).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   96.59%   96.38%   -0.21%     
==========================================
  Files          34       34              
  Lines        3405     3405              
  Branches      794      794              
==========================================
- Hits         3289     3282       -7     
  Misses         70       70              
- Partials       46       53       +7     

Flag	Coverage Δ
contracts/access	65.46% <ø> (ø)
contracts/allowance	52.40% <ø> (ø)
contracts/finance	26.07% <ø> (ø)
contracts/timelock	54.57% <ø> (ø)
contracts/utils	44.09% <ø> (ø)
math/core	86.38% <ø> (-0.52%)	⬇️
math/fixed_point	63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bidzyyys]

LGTM