[N-06] Collections audit

[ericnordelo]

Summary by CodeRabbit

• Bug Fixes
  • Improved ordered navigation and pagination operations for sorted maps.
  • Ensured search-based results are handled consistently when finding next or previous entries and retrieving keys from a starting point.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d11a5c65-5af2-45d7-927c-1e3c804a0eef

📥 Commits

Reviewing files that changed from the base of the PR and between 15eb9ac and eb41db9.

📒 Files selected for processing (1)

• collections/sources/sorted_map.move

---

📝 Walkthrough

Walkthrough

Three ordered-map macros now bind their input parameters to local variables before passing them to map.search!; macro signatures and return types remain unchanged.

Changes

Ordered map search macros

Layer / File(s)	Summary
Bind macro search inputs collections/sources/sorted_map.move	find_next_by, find_prev_by, and keys_from_by pass locally bound key, inclusion, and limit inputs to their ordered searches.

Estimated code review effort: 2 (Simple) | ~5 minutes

Suggested reviewers: 0xneshi, bidzyyys, immrsd

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided, so the required issue reference, change summary, and checklist are missing.	Add the template sections, including "Resolves #???", a brief change summary, and the Tests, Documentation, and Changelog checklist.
Title check	❓ Inconclusive	The title is related to the collections audit but is too vague to indicate the actual sorted_map macro changes.	Rename it to summarize the concrete change, e.g. "Adjust sorted_map navigation macros to bind local search args," so history is clearer.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/collections-audit-N-06

---

_{Comment @coderabbitai help to get the list of available commands.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.68%. Comparing base (15eb9ac) to head (6bc33dc).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #495   +/-   ##
=======================================
  Coverage   96.68%   96.68%           
=======================================
  Files          39       39           
  Lines        3895     3895           
  Branches      875      875           
=======================================
  Hits         3766     3766           
  Misses         74       74           
  Partials       55       55           

Flag	Coverage Δ
contracts/access	65.46% <ø> (ø)
contracts/allowance	52.40% <ø> (ø)
contracts/finance	26.66% <ø> (ø)
contracts/sale	48.59% <ø> (ø)
contracts/timelock	54.32% <ø> (ø)
contracts/utils	44.09% <ø> (ø)
math/core	86.97% <ø> (ø)
math/fixed_point	63.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bidzyyys]

LGTM