Skip to content

Fix Governor Cross-Chain Execution appearing as an empty dropdown - #834

Merged
ericglau merged 2 commits into
OpenZeppelin:masterfrom
ericglau:claude/cross-chain-execution-dropdown-obzbw6
Jul 31, 2026
Merged

Fix Governor Cross-Chain Execution appearing as an empty dropdown#834
ericglau merged 2 commits into
OpenZeppelin:masterfrom
ericglau:claude/cross-chain-execution-dropdown-obzbw6

Conversation

@ericglau

Copy link
Copy Markdown
Member

Cross-Chain Execution is a single boolean with no sub-options, but was rendered as an expandable section whose chevron toggled an empty region.

It's now a plain checkbox in the Settings group next to Storage, matching how other single-boolean Governor extensions appear.

claude added 2 commits July 31, 2026 22:18
Cross-Chain Execution is a single boolean with no sub-options, but it was
rendered with ExpandableCheckbox and no children, so the section showed an
expand chevron that toggled an empty region.

Move it into the Settings checkbox group alongside Storage, which is the
same shape of option (a single-boolean Governor extension).

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011ewjEsjUeARiP2RBB7uARM
@ericglau
ericglau requested review from a team as code owners July 31, 2026 22:23
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to OpenZeppelin Contracts Wizard. Before being able to integrate those changes, we would like you to sign our Contributor License Agreement.
You can sign the CLA by just posting a Pull Request Comment with the sentence below. Thanks.


I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The governor settings replace the expandable Cross-Chain Execution control with an inline checkbox. The checkbox includes an ERC-7786 gateway help link and describes the CrosschainRemoteExecutor requirement.

Changes

Governor controls

Layer / File(s) Summary
Inline cross-chain execution control
packages/ui/src/solidity/GovernorControls.svelte
The settings checkbox group now contains crossChainExecution with ERC-7786 documentation and CrosschainRemoteExecutor requirements. The standalone expandable control and its import were removed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: replacing the empty expandable control with a corrected Governor Cross-Chain Execution control.
Description check ✅ Passed The description directly explains the defect and the change to a plain checkbox in the Settings group.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/ui/src/solidity/GovernorControls.svelte`:
- Line 158: Update the HelpTooltip link in GovernorControls to point to the
stable official documentation anchor for the relevant GovernorCrosschain API,
replacing the nonexistent GovernorCrosschain anchor while preserving the
existing tooltip.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 23de498b-d83a-4fc7-bf21-fa6b0ba72289

📥 Commits

Reviewing files that changed from the base of the PR and between 3fa2e22 and 7a9e9a3.

📒 Files selected for processing (1)
  • packages/ui/src/solidity/GovernorControls.svelte

Comment thread packages/ui/src/solidity/GovernorControls.svelte
@ericglau
ericglau merged commit 195959d into OpenZeppelin:master Jul 31, 2026
21 of 22 checks passed
@ericglau
ericglau deleted the claude/cross-chain-execution-dropdown-obzbw6 branch July 31, 2026 22:34
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants