Fix Governor Cross-Chain Execution appearing as an empty dropdown - #834
Conversation
Cross-Chain Execution is a single boolean with no sub-options, but it was rendered with ExpandableCheckbox and no children, so the section showed an expand chevron that toggled an empty region. Move it into the Settings checkbox group alongside Storage, which is the same shape of option (a single-boolean Governor extension). Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ewjEsjUeARiP2RBB7uARM
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011ewjEsjUeARiP2RBB7uARM
|
Thank you for your contribution to OpenZeppelin Contracts Wizard. Before being able to integrate those changes, we would like you to sign our Contributor License Agreement. I confirm that I have read and hereby agree to the OpenZeppelin Contributor License Agreement You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
WalkthroughThe governor settings replace the expandable Cross-Chain Execution control with an inline checkbox. The checkbox includes an ERC-7786 gateway help link and describes the ChangesGovernor controls
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/solidity/GovernorControls.svelte`:
- Line 158: Update the HelpTooltip link in GovernorControls to point to the
stable official documentation anchor for the relevant GovernorCrosschain API,
replacing the nonexistent GovernorCrosschain anchor while preserving the
existing tooltip.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 23de498b-d83a-4fc7-bf21-fa6b0ba72289
📒 Files selected for processing (1)
packages/ui/src/solidity/GovernorControls.svelte
Cross-Chain Execution is a single boolean with no sub-options, but was rendered as an expandable section whose chevron toggled an empty region.
It's now a plain checkbox in the Settings group next to Storage, matching how other single-boolean Governor extensions appear.