[yAudit-03] Fix swap fee accrual on realized gain - #306
Merged
Conversation
naddison36
approved these changes
Jul 22, 2026
naddison36
left a comment
Collaborator
There was a problem hiding this comment.
This is a good find.
I've checked the new method is economically equivalent without rounding issues. The new method is better as it handles the rounding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invariant harness
The invariant handlers accept full-word uint256 inputs and derive booleans or bound narrower values internally. This prevents mutated calldata from reverting in the Solidity ABI dispatcher before handler execution.
Testing
Audit report
Related yAudit issue: https://github.com/yAudit/origin-paxos-adapter-review/issues/3